[m-rev.] for tryout and/or review: removing globals from the I/O state

[Zoltan Somogyi]

On 14-Oct-2009, Peter Wang <novalazy at gmail.com> wrote:
> > 	Add a det version of remove_suffix, for use by new code above.
>
> Update NEWS.

Will do.

> --- compiler/make.m     14 Aug 2009 20:37:46 -0000      1.60
> +++ compiler/make.m     12 Oct 2009 06:01:38 -0000
> @@ -609,8 +608,9 @@
>  option_table_hash(AllOptionArgs, Hash, !IO) :-
> -    globals.io_get_globals(Globals, !IO),
> -    handle_options(AllOptionArgs, OptionsErrors, _, _, _, !IO),
> +    handle_given_options(AllOptionArgs, _, _, _,
> +        OptionsErrors, UpdatedGlobals, !IO),
> +    % XXX We throw away UpdatedGlobals after computing its hash. Why? -zs
>
> We have no other use for the updated globals here.

I figured that, but in that case, why hash the updated globals and not the
original ones? Clearly, the updated globals are being hashed because they
will be or have been used, in which case, why do the update twice?

> +        % XXX I think the presence of this assignment here means that
> +        % `mmc --mmake' does not use this mechanism for linking, but I am
> +        % not sure. -zs
> +        Link = no,
>
> That's right.

Will update the comment.

Thanks for all the tryouts and reviews.

I have committed the diff. Since the diff changes the package to which
mark_static_terms belongs, you will need to remove up old, now misnamed files
(ml_backend.mark_static_terms.*) An "mmake clean" will do this if you
invoke it BEFORE you invoke "mmake depend", but not after; after, you will
need to remove them manually.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------