[m-rev.] for review: separate mlconst_int

Julien Fischer juliensf at csse.unimelb.edu.au
Fri Oct 9 16:33:00 AEDT 2009


On Fri, 9 Oct 2009, Peter Wang wrote:

> Branches: main
>
> Add `mlconst_enum' and `mlconst_char' to handle constants currently
> represented by `mlconst_int'.  This should make the Java backend more robust,
> where integers cannot (always) be used in place of characters or enumerations.
>
> compiler/mlds.m:
>        Add `mlconst_enum' and `mlconst_char' functors to the `ml_const' type.
>
> compiler/ml_switch_gen.m:
> compiler/ml_unify_gen.m:
> compiler/ml_util.m:
>        Generate `mlconst_char' or `mlconst_enum' from HLDS `int_tag' values.
>
> compiler/ml_type_gen.m:
>        Generate `mlconst_enum's for enumeration constants.
>
> compiler/ml_code_util.m:
>        Add predicate to return MLDS type for characters.
>
> compiler/mlds_to_java.m:
>        Simplify the backend as allowed by the new functors.
>
> compiler/ml_lookup_switch.m:
> compiler/ml_tailcall.m:
> compiler/mlds_to_c.m:
> compiler/mlds_to_gcc.m:
> compiler/mlds_to_il.m:
> compiler/mlds_to_managed.m:
> compiler/rtti_to_mlds.m:
>        Conform to changes.

That looks fine - please be sure to check it in a number of MLDS grades
before committing.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list