[m-rev.] for review: restore hl.gc
Julien Fischer
juliensf at csse.unimelb.edu.au
Mon Oct 5 14:51:29 AEDT 2009
On Mon, 5 Oct 2009, Peter Wang wrote:
> Branches: main
>
> Restore high-level data C grades.
>
> - Earlier, I inadvertently disabled unboxing of foreign input arguments in
> high-level data C grades.
>
> - Earlier, I incorrectly assumed that high-level data structures don't require
> secondary tag initialiser arguments, but that is only true when targetting an
> OOP language where the object constructor sets the secondary tag.
>
> compiler/ml_foreign_proc_gen.m:
> Make `input_arg_assignable_with_cast' fail on foreign type arguments
> without the `can_pass_as_mercury_type' assertion in hl.* grades, so the
> argument will be correctly unboxed.
>
> Rename HasSecTag variables to ExplicitSecTag.
>
> compiler/ml_type_gen.m:
> Export ml_target_uses_constructors.
>
> compiler/ml_unify_gen.m:
> Use ml_target_uses_constructors to decide if an explicit secondary tag
> argument is required when initialising a new object, not whether
> high-level data is in effect.
>
> Rename HasSecTag variables to ExplicitSecTag.
>
> compiler/mlds.m:
> Clarify that the `HasSecTag' field of `new_object' means whether an
> explicit secondary tag argument is at the head of the list of
> arguments, not whether objects of that type require secondary tags.
>
> Rename HasSecTag variables to ExplicitSecTag.
>
> compiler/mlds_to_il.m:
> Abort if we see a `new_object' with an explicit secondary tag, instead
> of skipping it.
>
> compiler/ml_accurate_gc.m:
> compiler/ml_elim_nested.m:
> compiler/ml_optimize.m:
> compiler/ml_util.m:
> compiler/mlds_to_c.m:
> compiler/mlds_to_gcc.m:
> compiler/mlds_to_java.m:
> compiler/structure_reuse.direct.choose_reuse.m:
> Rename HasSecTag variables to ExplicitSecTag.
That looks fine.
Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to: mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions: mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------
More information about the reviews
mailing list