[m-rev.] Re: for review: parsing_utils improvements

[Ralph Becket]

Ian MacLarty, Thursday,  1 October 2009:
> On Thu, Oct 01, 2009 at 01:49:48PM +1000, Ralph Becket wrote:
> > Ian MacLarty, Wednesday, 30 September 2009:
> > > On Wed, Sep 30, 2009 at 12:12 PM, Ian MacLarty
> > > <maclarty at csse.unimelb.edu.au> wrote:
> > > > Here are some benchmarks I did with the sparql parser with an input of
> > > > 4.8M (times are an average of 3 runs):
> > > 
> > > Correction: 48M (48 100 031 bytes).
> > 
> > Sorry, I thought I'd replied to this before: you've convinced me this is
> > a good idea!
> 
> Here's an interdiff for review.

That looks fine, except for consistency can you replace the ( -> ; )
constructs with ( if then else )?

> Note the whitespace bug fix.  It was
> using char.is_whitespace for the first character, but then calling
> skip_whitespace/3 which calls the user defined whitespace function.
> I changed it so it calls char.is_whitespace for all characters which is
> its documented behaviour.

Good catch.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------