[m-rev.] for review: gcc 4 with llds grades

Peter Wang novalazy at gmail.com
Thu Nov 26 15:56:44 AEDT 2009


Branches: main

compiler/purity.m:
        Downgrade an XXX.

diff --git a/compiler/purity.m b/compiler/purity.m
index 76baad6..56890fd 100644
--- a/compiler/purity.m
+++ b/compiler/purity.m
@@ -289,9 +289,9 @@ puritycheck_pred(PredId, !PredInfo, ModuleInfo, !Specs) :-
     WorstPurity = Purity,
     perform_pred_purity_checks(!.PredInfo, Purity, DeclPurity,
         PromisedPurity, PurityCheckResult0),
-    % XXX Work around a segfault while purity checking invalid/purity/purity.m.
-    % It seems to be due to gcc 4.1.2 on x86-64 miscompiling the computed
-    % goto following the workaround at gcc -O1 and above.
+    % This was to avoid a crash in the following computed goto, when compiled
+    % with gcc 4.1 on x86-64. The problem seems to be gone now, but there's not
+    % much to gain from removing the workaround.
     PurityCheckResult = workaround_gcc_bug(PurityCheckResult0),
     (
         PurityCheckResult = inconsistent_promise,

--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list