[m-rev.] for review: representation of ":- module" and ":- end_module"

Julien Fischer juliensf at csse.unimelb.edu.au
Thu Nov 5 14:00:17 AEDT 2009


On Wed, 4 Nov 2009, Zoltan Somogyi wrote:

> I am seeking feedback mostly on the user-visible change in behavior in
> the absence of :- module declarations at the starts of source files,
> though comments on the code are also welcome. I will fix the ZZZs before
> commit.

The new behaviour is fine by me.   I suggest s/should/must in the error
message, e.g.

     errors.m:010: Error: module must start with a `:- module' declaration.

instead of:

     errors.m:010: Error: module should start with a `:- module' declaration.

The former seems more direct.

The diff appears fine.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list