[m-rev.] for review: support STM in low level grades

[Ben Mellor]

> > +** MR_STM_block_thread is called to block the thread in high level C
> > grades, +** using POSIX thread facilities, as there is a POSIX thread for
> > every engine +** in these grades.
> 
> I suggest:
> 
>  	as there is one POSIX thread for every Mercury thread in these
>          grades.
> 
> (which is indeed what you say in equivalent comment in stm_builtin.m.)
> 
> (The high-level C backend does not use engines - except in a very dodgy
> fashion for implementing thread local mutables and thread local
> trailing.)
 
> > +    #define MR_STM_context_from_condvar(x)      (x->MR_STM_tl_thread)
> 
> Parenthesize the arguement in the macro body, e.g.
> 
>  	((x)->MR_STM_tl_thread)
 
> > +#if (!defined MR_HIGHLEVEL_CODE)
> 
>  	#if !defined(MR_HIGHLEVEL_CODE)
> 
> is the usual way the above is written throughout the rest of the
> runtime.


I have addressed all of these comments and committed.

Cheers,
-- Ben
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------