[m-rev.] diff: spurious `mercury' directories

Peter Wang novalazy at gmail.com
Mon Jun 15 14:30:59 AEST 2009


Branches: main

compiler/file_names.m:
        Make module_name_to_file_name not create mercury/* package directories
        for Java unless the MkDir argument says to do so.  Even if you wouldn't
        be using the java grade, when writing out dependencies the package
        directories would be created.  On case-insensitive filesystems, the
        `mercury' directory would be confused with the `Mercury' directory.

diff --git a/compiler/file_names.m b/compiler/file_names.m
index 8e2a2e1..b69795b 100644
--- a/compiler/file_names.m
+++ b/compiler/file_names.m
@@ -197,7 +197,7 @@ module_name_to_file_name_general(ModuleName, Ext,
Search, MkDir, FileName,
         ),
         BaseName = unqualify_name(JavaModuleName) ++ Ext,
         choose_file_name(ModuleName, BaseParentDirs, BaseName, Ext, Search,
-            do_create_dirs, FileName, !IO)
+            MkDir, FileName, !IO)
     ;
         % Erlang uses `.' as a package separator and expects a module
         % `a.b.c' to be in a file `a/b/c.erl'.  Rather than that, we use
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list