[m-rev.] for review: inline par_conj primitives

[Zoltan Somogyi]

On 11-Jun-2009, Peter Wang <novalazy at gmail.com> wrote:
> > +   PredName = new_pred_name,
> 
> new_future_pred_name would be better.

Done, and similarly for the other function names.

> > +%       "--no-inline-par-builtins",
> > +%       "\tGenerate calls to the predicates of par_builtin.m, instead of",
> > +%       "\tbodily including their definitions as C code.",
> > +%       Actually, this is the default for now.
> 
> The documentation is inverted, but I suppose you mean to make
> --inline-par-builtins the default, once it works.

If later benchmarking proves it to better, which I expect to be the case,
then yes.

> > +** Copyright (C) 2008 The University of Melbourne.
> 
> 2006-2009

Just 2009, since the file didn't exist in 2008.

Thanks for the review. I will commit the diff when I have checked that
it has no conflicts with my type_ctors in cons_ids diff.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------