[m-rev.] diff: Enable MR_PROFILE_PARALLEL_EXECUTION for nightly builds on taura.

Paul Bone pbone at csse.unimelb.edu.au
Tue Jul 14 10:20:25 AEST 2009


On Mon, Jul 13, 2009 at 11:26:55PM +1000, Julien Fischer wrote:
>
> On Mon, 13 Jul 2009, Paul Bone wrote:
>
>> Trivial diff:
>
> Not so!
>
>>
>> Enable MR_PROFILE_PARALLEL_EXECUTION in nightly builds on taura.
>
> MR_PROFILE_PARALLEL_EXECUTION is currently defined as an enumeration
> constant.  You cannot also use it as preprocessor macro - the resulting
> expansion will cause the enum declaration to be syntatically invalid.
>
> I notice that you have defined (but not documented) a macro
> MR_PROFILE_PARALLEL_EXECUTION_SUPPORT.  That appears to be the one
> you should be using.  Note that such configuration parameters should
> be documented in runtime/mercury_conf_param.h.
>

I notice that MR_LL_PARALLEL_CONJ is not documented in this file (but is
defined when MR_THREAD_SAFE is defined and MR_HIGH_LEVEL_CODE isn't.  Should
this also be documented?

Thanks.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 489 bytes
Desc: Digital signature
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20090714/1b5b25d1/attachment.sig>


More information about the reviews mailing list