[m-rev.] for review: duplicating fields from type defns to cons defns

Zoltan Somogyi zs at csse.unimelb.edu.au
Mon Jan 12 13:07:27 AEDT 2009
Previous message: [m-rev.] for post-commit review: optimizing goal features
Next message: [m-rev.] for review: duplicating fields from type defns to cons defns
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Duplicate some fields of each hlds_type_defn to the cons_defns of its data
constructors. This way, the type analysis algorithm can avoid the need for
a separate lookup in the type table. Since we are only copying references
to terms that are never updated and are always live throughout execution
anyway to other terms that are never updated and are always live throughout
execution anyway, the only cost is only a few bytes per cons_id.

compiler/hlds_data.m:
	Add a tvarset field to the cons_defn types, and put the other fields
	in a more logical order.

compiler/add_type.m:
	Make the duplications.

compiler/type_util.m:
	Delete a predicate that looked up both a type_ctor's and a cons_id's
	defn, since its callers now need only the cons_id's definition. Replace
	with a det version of an existing semidet predicate that does the
	lookup of the cons_id's definition.

compiler/intermod.m:
compiler/ml_unify_gen.m:
compiler/post_typecheck.m:
compiler/recompilation.usage.m:
compiler/typecheck.m:
	Conform to the changes above.

Zoltan.

cvs diff: Diffing .
cvs diff: Diffing analysis
cvs diff: Diffing bindist
cvs diff: Diffing boehm_gc
cvs diff: Diffing boehm_gc/Mac_files
cvs diff: Diffing boehm_gc/cord
cvs diff: Diffing boehm_gc/cord/private
cvs diff: Diffing boehm_gc/doc
cvs diff: Diffing boehm_gc/include
cvs diff: Diffing boehm_gc/include/private
cvs diff: Diffing boehm_gc/libatomic_ops-1.2
cvs diff: Diffing boehm_gc/libatomic_ops-1.2/doc
cvs diff: Diffing boehm_gc/libatomic_ops-1.2/src
cvs diff: Diffing boehm_gc/libatomic_ops-1.2/src/atomic_ops
cvs diff: Diffing boehm_gc/libatomic_ops-1.2/src/atomic_ops/sysdeps
cvs diff: Diffing boehm_gc/libatomic_ops-1.2/src/atomic_ops/sysdeps/gcc
cvs diff: Diffing boehm_gc/libatomic_ops-1.2/src/atomic_ops/sysdeps/hpc
cvs diff: Diffing boehm_gc/libatomic_ops-1.2/src/atomic_ops/sysdeps/ibmc
cvs diff: Diffing boehm_gc/libatomic_ops-1.2/src/atomic_ops/sysdeps/icc
cvs diff: Diffing boehm_gc/libatomic_ops-1.2/src/atomic_ops/sysdeps/msftc
cvs diff: Diffing boehm_gc/libatomic_ops-1.2/src/atomic_ops/sysdeps/sunc
cvs diff: Diffing boehm_gc/libatomic_ops-1.2/tests
cvs diff: Diffing boehm_gc/tests
cvs diff: Diffing boehm_gc/windows-untested
cvs diff: Diffing boehm_gc/windows-untested/vc60
cvs diff: Diffing boehm_gc/windows-untested/vc70
cvs diff: Diffing boehm_gc/windows-untested/vc71
cvs diff: Diffing browser
cvs diff: Diffing bytecode
cvs diff: Diffing compiler
Index: compiler/add_type.m
===================================================================
RCS file: /home/mercury/mercury1/repository/mercury/compiler/add_type.m,v
retrieving revision 1.32
diff -u -b -r1.32 add_type.m
--- compiler/add_type.m	11 Feb 2008 21:25:50 -0000	1.32
+++ compiler/add_type.m	10 Jan 2009 13:27:58 -0000
@@ -361,6 +361,7 @@
     get_type_defn_context(TypeDefn, Context),
     get_type_defn_tvarset(TypeDefn, TVarSet),
     get_type_defn_tparams(TypeDefn, Args),
+    get_type_defn_kind_map(TypeDefn, KindMap),
     get_type_defn_body(TypeDefn, Body),
     get_type_defn_status(TypeDefn, Status),
     get_type_defn_need_qualifier(TypeDefn, NeedQual),
@@ -370,7 +371,7 @@
         module_info_get_cons_table(!.ModuleInfo, Ctors0),
         module_info_get_partial_qualifier_info(!.ModuleInfo, PQInfo),
         module_info_get_ctor_field_table(!.ModuleInfo, CtorFields0),
-        ctors_add(ConsList, TypeCtor, TVarSet, NeedQual, PQInfo,
+        ctors_add(ConsList, TypeCtor, TVarSet, Args, KindMap, NeedQual, PQInfo,
             Context, Status, CtorFields0, CtorFields, Ctors0, Ctors,
             [], CtorAddSpecs),
         module_info_set_cons_table(Ctors, !ModuleInfo),
@@ -675,32 +676,34 @@
     ).
 
 :- pred ctors_add(list(constructor)::in, type_ctor::in, tvarset::in,
-    need_qualifier::in, partial_qualifier_info::in, prog_context::in,
+    list(type_param)::in, tvar_kind_map::in, need_qualifier::in,
+    partial_qualifier_info::in, prog_context::in,
     import_status::in, ctor_field_table::in, ctor_field_table::out,
     cons_table::in, cons_table::out,
     list(error_spec)::in, list(error_spec)::out) is det.
 
-ctors_add([], _, _, _, _, _, _, !FieldNameTable, !Ctors, !Specs).
-ctors_add([Ctor | Rest], TypeCtor, TVarSet, NeedQual, PQInfo, _Context,
-        ImportStatus, !FieldNameTable, !Ctors, !Specs) :-
+ctors_add([], _, _, _, _, _, _, _, _, !FieldNameTable, !Ctors, !Specs).
+ctors_add([Ctor | Rest], TypeCtor, TVarSet, TypeParams, KindMap, NeedQual,
+        PQInfo, _Context, ImportStatus, !FieldNameTable, !Ctors, !Specs) :-
     Ctor = ctor(ExistQVars, Constraints, Name, Args, Context),
     QualifiedConsId = make_cons_id(Name, Args, TypeCtor),
-    ConsDefn = hlds_cons_defn(ExistQVars, Constraints, Args, TypeCtor,
-        Context),
-    %
-    % Insert the fully-qualified version of this cons_id into the
-    % cons_table.
-    % Also check that there is at most one definition of a given
-    % cons_id in each type.
-    %
+    ConsDefn = hlds_cons_defn(TypeCtor, TVarSet, TypeParams, KindMap,
+        ExistQVars, Constraints, Args, Context),
+
+    % Insert the fully-qualified version of this cons_id into the cons_table.
+    % Also check that there is at most one definition of a given cons_id
+    % in each type.
+
     ( map.search(!.Ctors, QualifiedConsId, QualifiedConsDefns0) ->
         QualifiedConsDefns1 = QualifiedConsDefns0
     ;
         QualifiedConsDefns1 = []
     ),
     (
+        some [OtherConsDefn] (
         list.member(OtherConsDefn, QualifiedConsDefns1),
-        OtherConsDefn = hlds_cons_defn(_, _, _, TypeCtor, _)
+            OtherConsDefn ^ cons_type_ctor = TypeCtor
+        )
     ->
         QualifiedConsIdStr = cons_id_to_string(QualifiedConsId),
         TypeCtorStr = type_ctor_to_string(TypeCtor),
@@ -741,8 +744,8 @@
     ;
         unexpected(this_file, "ctors_add: cons_id not qualified")
     ),
-    ctors_add(Rest, TypeCtor, TVarSet, NeedQual, PQInfo, Context,
-        ImportStatus, !FieldNameTable, !Ctors, !Specs).
+    ctors_add(Rest, TypeCtor, TVarSet, TypeParams, KindMap, NeedQual,
+        PQInfo, Context, ImportStatus, !FieldNameTable, !Ctors, !Specs).
 
 :- pred add_ctor(string::in, int::in, hlds_cons_defn::in, module_name::in,
     cons_id::out, cons_table::in, cons_table::out) is det.
Index: compiler/hlds_data.m
===================================================================
RCS file: /home/mercury/mercury1/repository/mercury/compiler/hlds_data.m,v
retrieving revision 1.122
diff -u -b -r1.122 hlds_data.m
--- compiler/hlds_data.m	4 Sep 2008 11:41:00 -0000	1.122
+++ compiler/hlds_data.m	10 Jan 2009 12:49:00 -0000
@@ -59,25 +59,30 @@
     %
 :- type hlds_cons_defn
     --->    hlds_cons_defn(
-                % maybe add tvarset here?
-                % you can get the tvarset from the hlds.type_defn.
-                cons_exist_tvars    :: existq_tvars,
-                                    % existential type vars
+                % The result type, i.e. the type constructor to which this
+                % cons_defn belongs.
+                cons_type_ctor      :: type_ctor,
 
+                % These three fields are copies of the first three fields
+                % of the hlds_type_defn for cons_type_ctor. They specify
+                % the tvarset from which the type variables in the argument
+                % types come, the type constructor's type parameter list,
+                % and the kinds of the type variables.
+                cons_type_tvarset   :: tvarset,
+                cons_type_params    :: list(type_param),
+                cons_type_kinds     :: tvar_kind_map,
+
+                % Existential type variables and class constraints.
+                cons_exist_tvars    :: existq_tvars,
                 cons_constraints    :: list(prog_constraint),
-                                    % existential class constraints
 
+                % The field names and types of the arguments of this functor
+                % (if any).
                 cons_args           :: list(constructor_arg),
-                                    % The field names and types of the
-                                    % arguments of this functor (if any)
-
-                cons_type_ctor      :: type_ctor,
-                                    % The result type, i.e. the type to which
-                                    % this cons_defn belongs.
 
+                % The location of this constructor definition in the
+                % original source code.
                 cons_context        :: prog_context
-                                    % The location of this constructor
-                                    % definition in the original source code.
             ).
 
 %-----------------------------------------------------------------------------%
@@ -477,6 +482,10 @@
 
 :- type hlds_type_defn
     --->    hlds_type_defn(
+                % Note that the first three of these fields are duplicated
+                % in the hlds_cons_defns of the data constructors of the type
+                % (if any).
+
                 % Names of the type variables, if any.
                 type_defn_tvarset           :: tvarset,
 
Index: compiler/intermod.m
===================================================================
RCS file: /home/mercury/mercury1/repository/mercury/compiler/intermod.m,v
retrieving revision 1.240
diff -u -b -r1.240 intermod.m
--- compiler/intermod.m	2 Jan 2009 03:12:07 -0000	1.240
+++ compiler/intermod.m	10 Jan 2009 13:30:33 -0000
@@ -979,12 +979,12 @@
     ->
         TypeCtors1 = list.map(
             (func(ConsDefn) = TypeCtor :-
-                ConsDefn = hlds_cons_defn(_, _, _, TypeCtor, _)
+                ConsDefn ^ cons_type_ctor = TypeCtor
             ), MatchingConstructors)
     ;
         TypeCtors1 = []
     ),
-    TypeCtors = list.append(TypeCtors0, TypeCtors1),
+    TypeCtors = TypeCtors0 ++ TypeCtors1,
 
     module_info_get_predicate_table(ModuleInfo, PredicateTable),
     (
Index: compiler/ml_unify_gen.m
===================================================================
RCS file: /home/mercury/mercury1/repository/mercury/compiler/ml_unify_gen.m,v
retrieving revision 1.126
diff -u -b -r1.126 ml_unify_gen.m
--- compiler/ml_unify_gen.m	5 Jan 2009 01:30:51 -0000	1.126
+++ compiler/ml_unify_gen.m	10 Jan 2009 13:28:43 -0000
@@ -1034,7 +1034,7 @@
         (
             type_util.get_cons_defn(ModuleInfo, TypeCtor, CtorId, ConsDefn)
         ->
-            ConsDefn = hlds_cons_defn(_, _, ConsArgDefns, _, _),
+            ConsArgDefns = ConsDefn ^ cons_args,
             ConsArgTypes0 = list.map(func(C) = C ^ arg_type, ConsArgDefns),
 
             % There may have been additional types inserted to hold the
@@ -1532,9 +1532,9 @@
         Fields = list.map(MakeUnnamedField, FieldTypes)
     ;
         ml_gen_info_get_module_info(Info, ModuleInfo),
-        type_util.get_type_and_cons_defn(ModuleInfo, Type, ConsId,
-            _TypeDefn, ConsDefn),
-        ConsDefn = hlds_cons_defn(_, _, Fields0, _, _),
+        type_to_ctor_det(Type, TypeCtor),
+        get_cons_defn_det(ModuleInfo, TypeCtor, ConsId, ConsDefn),
+        Fields0 = ConsDefn ^ cons_args,
 
         % Add the fields for any type_infos and/or typeclass_infos inserted
         % for existentially quantified data types. For these, we just copy
Index: compiler/post_typecheck.m
===================================================================
RCS file: /home/mercury/mercury1/repository/mercury/compiler/post_typecheck.m,v
retrieving revision 1.129
diff -u -b -r1.129 post_typecheck.m
--- compiler/post_typecheck.m	8 Sep 2008 04:35:53 -0000	1.129
+++ compiler/post_typecheck.m	10 Jan 2009 13:23:20 -0000
@@ -1103,7 +1103,8 @@
     list.member(ConsDefn, ConsDefns),
 
     % Overloading resolution ignores the class constraints.
-    ConsDefn = hlds_cons_defn(ConsExistQVars, _, ConsArgs, ConsTypeCtor, _),
+    ConsDefn = hlds_cons_defn(ConsTypeCtor, _, _, _, ConsExistQVars, _,
+        ConsArgs, _),
     ConsTypeCtor = TypeCtor,
 
     module_info_get_type_table(ModuleInfo, Types),
@@ -1277,9 +1278,10 @@
 get_cons_id_arg_types_adding_existq_tvars(ModuleInfo, GoalPath, ConsId,
         TermType, ActualArgTypes, ActualExistQVars, !PredInfo) :-
     % Split the list of argument types at the named field.
-    type_util.get_type_and_cons_defn(ModuleInfo, TermType, ConsId,
-        TypeDefn, ConsDefn),
-    ConsDefn = hlds_cons_defn(ConsExistQVars, ConsConstraints, ConsArgs, _, _),
+    type_to_ctor_det(TermType, TypeCtor),
+    get_cons_defn_det(ModuleInfo, TypeCtor, ConsId, ConsDefn),
+    ConsDefn = hlds_cons_defn(_, _, TypeParams, _, ConsExistQVars,
+        ConsConstraints, ConsArgs, _),
     ConsArgTypes = list.map(func(C) = C ^ arg_type, ConsArgs),
 
     (
@@ -1324,7 +1326,6 @@
             unexpected(this_file, "existq_tvar bound to non-var")
         )
     ),
-    hlds_data.get_type_defn_tparams(TypeDefn, TypeParams),
     ( type_to_ctor_and_args(TermType, _, TypeArgs) ->
         map.from_corresponding_lists(TypeParams, TypeArgs, UnivTSubst)
     ;
Index: compiler/prog_data.m
===================================================================
RCS file: /home/mercury/mercury1/repository/mercury/compiler/prog_data.m,v
retrieving revision 1.214
diff -u -b -r1.214 prog_data.m
Index: compiler/recompilation.usage.m
===================================================================
RCS file: /home/mercury/mercury1/repository/mercury/compiler/recompilation.usage.m,v
retrieving revision 1.48
diff -u -b -r1.48 recompilation.usage.m
--- compiler/recompilation.usage.m	21 Jul 2008 03:10:14 -0000	1.48
+++ compiler/recompilation.usage.m	10 Jan 2009 13:31:15 -0000
@@ -747,7 +747,7 @@
     MatchingConstructors =
         list.map(
             (func(ConsDefn) = Ctor :-
-                ConsDefn = hlds_cons_defn(_,_,_, TypeCtor, _),
+                ConsDefn ^ cons_type_ctor = TypeCtor,
                 Ctor = resolved_functor_constructor(
                     type_ctor_to_item_name(TypeCtor))
             ),
Index: compiler/type_util.m
===================================================================
RCS file: /home/mercury/mercury1/repository/mercury/compiler/type_util.m,v
retrieving revision 1.194
diff -u -b -r1.194 type_util.m
--- compiler/type_util.m	27 Aug 2008 03:58:43 -0000	1.194
+++ compiler/type_util.m	10 Jan 2009 13:22:49 -0000
@@ -215,21 +215,17 @@
 :- pred cons_id_arg_types(module_info::in, mer_type::in,
     cons_id::out, list(mer_type)::out) is nondet.
 
-    % Given a type and a cons_id, look up the definitions of that type
-    % and constructor. Aborts if the cons_id is not user-defined.
+    % Given a type constructor and one of its cons_ids, look up the definition
+    % of that cons_id. Aborts if the cons_id is not user-defined.
     % Note that this will NOT bind type variables in the functor's argument
     % types; they will be left unbound, so the caller can find out the
     % original types from the constructor definition. The caller must do
     % that substitution itself if required.
     %
-:- pred get_type_and_cons_defn(module_info::in, mer_type::in,
-    cons_id::in, hlds_type_defn::out, hlds_cons_defn::out) is det.
-
-    % Like get_type_and_cons_defn (above), except that it only returns
-    % the definition of the constructor, not the type.
-    %
 :- pred get_cons_defn(module_info::in, type_ctor::in, cons_id::in,
     hlds_cons_defn::out) is semidet.
+:- pred get_cons_defn_det(module_info::in, type_ctor::in, cons_id::in,
+    hlds_cons_defn::out) is det.
 
     % Given a type and a cons_id, look up the definition of that constructor;
     % if it is existentially typed, return its definition, otherwise fail.
@@ -938,13 +934,11 @@
         ->
             ArgTypes = TypeArgs
         ;
-            do_get_type_and_cons_defn(ModuleInfo, TypeCtor, ConsId, TypeDefn,
-                ConsDefn),
-            ConsDefn = hlds_cons_defn(ExistQVars0, _Constraints0, Args, _, _),
+            get_cons_defn(ModuleInfo, TypeCtor, ConsId, ConsDefn),
+            ConsDefn = hlds_cons_defn(_, _, TypeParams, _, ExistQVars0, _,
+                Args, _),
             Args = [_ | _]
         ->
-            hlds_data.get_type_defn_tparams(TypeDefn, TypeParams),
-
             % XXX handle ExistQVars
             (
                 ExistQVars0 = []
@@ -981,42 +975,21 @@
     map.lookup(Ctors, ConsId, ConsDefns),
     list.member(ConsDefn, ConsDefns),
 
-    ConsDefn = hlds_cons_defn(ExistQVars0, _, Args, TypeCtor, _),
+    ConsDefn = hlds_cons_defn(TypeCtor, _, TypeParams, _, ExistQVars0, _,
+        Args, _),
 
     % XXX handle ExistQVars
     ExistQVars0 = [],
 
-    hlds_data.get_type_defn_tparams(TypeDefn, TypeParams),
-
     map.from_corresponding_lists(TypeParams, TypeArgs, TSubst),
     ArgTypes0 = list.map(func(C) = C ^ arg_type, Args),
     apply_subst_to_type_list(TSubst, ArgTypes0, ArgTypes).
 
-is_existq_cons(ModuleInfo, VarType, ConsId) :-
-    is_existq_cons(ModuleInfo, VarType, ConsId, _).
-
 :- pred is_existq_cons(module_info::in, mer_type::in, cons_id::in,
     hlds_cons_defn::out) is semidet.
 
-get_type_and_cons_defn(ModuleInfo, Type, ConsId, TypeDefn, ConsDefn) :-
-    (
-        type_to_ctor_and_args(Type, TypeCtor, _),
-        do_get_type_and_cons_defn(ModuleInfo,
-            TypeCtor, ConsId, TypeDefnPrime, ConsDefnPrime)
-    ->
-        TypeDefn = TypeDefnPrime,
-        ConsDefn = ConsDefnPrime
-    ;
-        unexpected(this_file, "get_type_and_cons_defn")
-    ).
-
-:- pred do_get_type_and_cons_defn(module_info::in, type_ctor::in, cons_id::in,
-    hlds_type_defn::out, hlds_cons_defn::out) is semidet.
-
-do_get_type_and_cons_defn(ModuleInfo, TypeCtor, ConsId, TypeDefn, ConsDefn) :-
-    get_cons_defn(ModuleInfo, TypeCtor, ConsId, ConsDefn),
-    module_info_get_type_table(ModuleInfo, Types),
-    map.lookup(Types, TypeCtor, TypeDefn).
+is_existq_cons(ModuleInfo, VarType, ConsId) :-
+    is_existq_cons(ModuleInfo, VarType, ConsId, _).
 
 get_cons_defn(ModuleInfo, TypeCtor, ConsId, ConsDefn) :-
     module_info_get_cons_table(ModuleInfo, Ctors),
@@ -1024,22 +997,22 @@
     map.search(Ctors, ConsId, ConsDefns),
     MatchingCons =
         (pred(ThisConsDefn::in) is semidet :-
-            ThisConsDefn = hlds_cons_defn(_, _, _, TypeCtor, _)
+            ThisConsDefn ^ cons_type_ctor = TypeCtor
         ),
     list.filter(MatchingCons, ConsDefns, [ConsDefn]).
 
-    % Given a type and a cons_id, look up the definition of that constructor;
-    % if it is existentially typed, return its definition, otherwise fail.
+get_cons_defn_det(ModuleInfo, TypeCtor, ConsId, ConsDefn) :-
+    ( get_cons_defn(ModuleInfo, TypeCtor, ConsId, ConsDefnPrime) ->
+        ConsDefn = ConsDefnPrime
+    ;
+        unexpected(this_file, "get_cons_defn_det: get_cons_defn failed")
+    ).
+
 get_existq_cons_defn(ModuleInfo, VarType, ConsId, CtorDefn) :-
     is_existq_cons(ModuleInfo, VarType, ConsId, ConsDefn),
-    ConsDefn = hlds_cons_defn(ExistQVars, Constraints, Args, _, _),
+    ConsDefn = hlds_cons_defn(_TypeCtor, TypeVarSet, TypeParams, KindMap,
+        ExistQVars, Constraints, Args, _Context),
     ArgTypes = list.map(func(C) = C ^ arg_type, Args),
-    module_info_get_type_table(ModuleInfo, Types),
-    type_to_ctor_and_args(VarType, TypeCtor, _),
-    map.lookup(Types, TypeCtor, TypeDefn),
-    hlds_data.get_type_defn_tvarset(TypeDefn, TypeVarSet),
-    hlds_data.get_type_defn_tparams(TypeDefn, TypeParams),
-    hlds_data.get_type_defn_kind_map(TypeDefn, KindMap),
     prog_type.var_list_to_type_list(KindMap, TypeParams, TypeCtorArgs),
     type_to_ctor_and_args(VarType, TypeCtor, _),
     construct_type(TypeCtor, TypeCtorArgs, RetType),
@@ -1049,8 +1022,7 @@
 is_existq_cons(ModuleInfo, VarType, ConsId, ConsDefn) :-
     type_to_ctor_and_args(VarType, TypeCtor, _),
     get_cons_defn(ModuleInfo, TypeCtor, ConsId, ConsDefn),
-    ConsDefn = hlds_cons_defn(ExistQVars, _, _, _, _),
-    ExistQVars = [_ | _].
+    ConsDefn ^ cons_exist_tvars = [_ | _].
 
 %-----------------------------------------------------------------------------%
 
Index: compiler/typecheck.m
===================================================================
RCS file: /home/mercury/mercury1/repository/mercury/compiler/typecheck.m,v
retrieving revision 1.434
diff -u -b -r1.434 typecheck.m
--- compiler/typecheck.m	23 Dec 2008 01:37:41 -0000	1.434
+++ compiler/typecheck.m	10 Jan 2009 13:24:22 -0000
@@ -2926,14 +2926,11 @@
     % recording the result, or by putting the result into the HLDS_ConsDefn
     % or some related data structure.
 
-    HLDS_ConsDefn = hlds_cons_defn(ExistQVars0, ExistProgConstraints, Args,
-        TypeCtor, _),
+    HLDS_ConsDefn = hlds_cons_defn(TypeCtor, ConsTypeVarSet, ConsTypeParams,
+        ConsTypeKinds, ExistQVars0, ExistProgConstraints, Args, _),
     ArgTypes = list.map(func(C) = C ^ arg_type, Args),
     typecheck_info_get_types(Info, Types),
     map.lookup(Types, TypeCtor, TypeDefn),
-    hlds_data.get_type_defn_tvarset(TypeDefn, ConsTypeVarSet),
-    hlds_data.get_type_defn_tparams(TypeDefn, ConsTypeParams),
-    hlds_data.get_type_defn_kind_map(TypeDefn, ConsTypeKinds),
     hlds_data.get_type_defn_body(TypeDefn, Body),
 
     % If this type has `:- pragma foreign_type' declarations, we
cvs diff: Diffing compiler/notes
cvs diff: Diffing debian
cvs diff: Diffing debian/patches
cvs diff: Diffing deep_profiler
cvs diff: Diffing deep_profiler/notes
cvs diff: Diffing doc
cvs diff: Diffing extras
cvs diff: Diffing extras/base64
cvs diff: Diffing extras/cgi
cvs diff: Diffing extras/complex_numbers
cvs diff: Diffing extras/complex_numbers/samples
cvs diff: Diffing extras/complex_numbers/tests
cvs diff: Diffing extras/concurrency
cvs diff: Diffing extras/curs
cvs diff: Diffing extras/curs/samples
cvs diff: Diffing extras/curses
cvs diff: Diffing extras/curses/sample
cvs diff: Diffing extras/dynamic_linking
cvs diff: Diffing extras/error
cvs diff: Diffing extras/fixed
cvs diff: Diffing extras/gator
cvs diff: Diffing extras/gator/generations
cvs diff: Diffing extras/gator/generations/1
cvs diff: Diffing extras/graphics
cvs diff: Diffing extras/graphics/easyx
cvs diff: Diffing extras/graphics/easyx/samples
cvs diff: Diffing extras/graphics/mercury_allegro
cvs diff: Diffing extras/graphics/mercury_allegro/examples
cvs diff: Diffing extras/graphics/mercury_allegro/samples
cvs diff: Diffing extras/graphics/mercury_allegro/samples/demo
cvs diff: Diffing extras/graphics/mercury_allegro/samples/mandel
cvs diff: Diffing extras/graphics/mercury_allegro/samples/pendulum2
cvs diff: Diffing extras/graphics/mercury_allegro/samples/speed
cvs diff: Diffing extras/graphics/mercury_glut
cvs diff: Diffing extras/graphics/mercury_opengl
cvs diff: Diffing extras/graphics/mercury_tcltk
cvs diff: Diffing extras/graphics/samples
cvs diff: Diffing extras/graphics/samples/calc
cvs diff: Diffing extras/graphics/samples/gears
cvs diff: Diffing extras/graphics/samples/maze
cvs diff: Diffing extras/graphics/samples/pent
cvs diff: Diffing extras/lazy_evaluation
cvs diff: Diffing extras/lex
cvs diff: Diffing extras/lex/samples
cvs diff: Diffing extras/lex/tests
cvs diff: Diffing extras/log4m
cvs diff: Diffing extras/logged_output
cvs diff: Diffing extras/moose
cvs diff: Diffing extras/moose/samples
cvs diff: Diffing extras/moose/tests
cvs diff: Diffing extras/mopenssl
cvs diff: Diffing extras/morphine
cvs diff: Diffing extras/morphine/non-regression-tests
cvs diff: Diffing extras/morphine/scripts
cvs diff: Diffing extras/morphine/source
cvs diff: Diffing extras/net
cvs diff: Diffing extras/odbc
cvs diff: Diffing extras/posix
cvs diff: Diffing extras/posix/samples
cvs diff: Diffing extras/quickcheck
cvs diff: Diffing extras/quickcheck/tutes
cvs diff: Diffing extras/references
cvs diff: Diffing extras/references/samples
cvs diff: Diffing extras/references/tests
cvs diff: Diffing extras/solver_types
cvs diff: Diffing extras/solver_types/library
cvs diff: Diffing extras/trailed_update
cvs diff: Diffing extras/trailed_update/samples
cvs diff: Diffing extras/trailed_update/tests
cvs diff: Diffing extras/windows_installer_generator
cvs diff: Diffing extras/windows_installer_generator/sample
cvs diff: Diffing extras/windows_installer_generator/sample/images
cvs diff: Diffing extras/xml
cvs diff: Diffing extras/xml/samples
cvs diff: Diffing extras/xml_stylesheets
cvs diff: Diffing java
cvs diff: Diffing java/runtime
cvs diff: Diffing library
cvs diff: Diffing mdbcomp
cvs diff: Diffing profiler
cvs diff: Diffing robdd
cvs diff: Diffing runtime
cvs diff: Diffing runtime/GETOPT
cvs diff: Diffing runtime/machdeps
cvs diff: Diffing samples
cvs diff: Diffing samples/c_interface
cvs diff: Diffing samples/c_interface/c_calls_mercury
cvs diff: Diffing samples/c_interface/cplusplus_calls_mercury
cvs diff: Diffing samples/c_interface/mercury_calls_c
cvs diff: Diffing samples/c_interface/mercury_calls_cplusplus
cvs diff: Diffing samples/c_interface/mercury_calls_fortran
cvs diff: Diffing samples/c_interface/simpler_c_calls_mercury
cvs diff: Diffing samples/c_interface/simpler_cplusplus_calls_mercury
cvs diff: Diffing samples/c_interface/standalone_c
cvs diff: Diffing samples/diff
cvs diff: Diffing samples/muz
cvs diff: Diffing samples/rot13
cvs diff: Diffing samples/solutions
cvs diff: Diffing samples/solver_types
cvs diff: Diffing samples/tests
cvs diff: Diffing samples/tests/c_interface
cvs diff: Diffing samples/tests/c_interface/c_calls_mercury
cvs diff: Diffing samples/tests/c_interface/cplusplus_calls_mercury
cvs diff: Diffing samples/tests/c_interface/mercury_calls_c
cvs diff: Diffing samples/tests/c_interface/mercury_calls_cplusplus
cvs diff: Diffing samples/tests/c_interface/mercury_calls_fortran
cvs diff: Diffing samples/tests/c_interface/simpler_c_calls_mercury
cvs diff: Diffing samples/tests/c_interface/simpler_cplusplus_calls_mercury
cvs diff: Diffing samples/tests/diff
cvs diff: Diffing samples/tests/muz
cvs diff: Diffing samples/tests/rot13
cvs diff: Diffing samples/tests/solutions
cvs diff: Diffing samples/tests/toplevel
cvs diff: Diffing scripts
cvs diff: Diffing slice
cvs diff: Diffing ssdb
cvs diff: Diffing tests
cvs diff: Diffing tests/analysis
cvs diff: Diffing tests/analysis/ctgc
cvs diff: Diffing tests/analysis/excp
cvs diff: Diffing tests/analysis/ext
cvs diff: Diffing tests/analysis/sharing
cvs diff: Diffing tests/analysis/table
cvs diff: Diffing tests/analysis/trail
cvs diff: Diffing tests/analysis/unused_args
cvs diff: Diffing tests/benchmarks
cvs diff: Diffing tests/debugger
cvs diff: Diffing tests/debugger/declarative
cvs diff: Diffing tests/dppd
cvs diff: Diffing tests/general
cvs diff: Diffing tests/general/accumulator
cvs diff: Diffing tests/general/string_format
cvs diff: Diffing tests/general/structure_reuse
cvs diff: Diffing tests/grade_subdirs
cvs diff: Diffing tests/hard_coded
cvs diff: Diffing tests/hard_coded/exceptions
cvs diff: Diffing tests/hard_coded/purity
cvs diff: Diffing tests/hard_coded/sub-modules
cvs diff: Diffing tests/hard_coded/typeclasses
cvs diff: Diffing tests/invalid
cvs diff: Diffing tests/invalid/purity
cvs diff: Diffing tests/misc_tests
cvs diff: Diffing tests/mmc_make
cvs diff: Diffing tests/mmc_make/lib
cvs diff: Diffing tests/par_conj
cvs diff: Diffing tests/recompilation
cvs diff: Diffing tests/stm
cvs diff: Diffing tests/stm/orig
cvs diff: Diffing tests/stm/orig/stm-compiler
cvs diff: Diffing tests/stm/orig/stm-compiler/test1
cvs diff: Diffing tests/stm/orig/stm-compiler/test10
cvs diff: Diffing tests/stm/orig/stm-compiler/test2
cvs diff: Diffing tests/stm/orig/stm-compiler/test3
cvs diff: Diffing tests/stm/orig/stm-compiler/test4
cvs diff: Diffing tests/stm/orig/stm-compiler/test5
cvs diff: Diffing tests/stm/orig/stm-compiler/test6
cvs diff: Diffing tests/stm/orig/stm-compiler/test7
cvs diff: Diffing tests/stm/orig/stm-compiler/test8
cvs diff: Diffing tests/stm/orig/stm-compiler/test9
cvs diff: Diffing tests/stm/orig/stm-compiler-par
cvs diff: Diffing tests/stm/orig/stm-compiler-par/bm1
cvs diff: Diffing tests/stm/orig/stm-compiler-par/bm2
cvs diff: Diffing tests/stm/orig/stm-compiler-par/stmqueue
cvs diff: Diffing tests/stm/orig/stm-compiler-par/test1
cvs diff: Diffing tests/stm/orig/stm-compiler-par/test10
cvs diff: Diffing tests/stm/orig/stm-compiler-par/test11
cvs diff: Diffing tests/stm/orig/stm-compiler-par/test2
cvs diff: Diffing tests/stm/orig/stm-compiler-par/test3
cvs diff: Diffing tests/stm/orig/stm-compiler-par/test4
cvs diff: Diffing tests/stm/orig/stm-compiler-par/test5
cvs diff: Diffing tests/stm/orig/stm-compiler-par/test6
cvs diff: Diffing tests/stm/orig/stm-compiler-par/test7
cvs diff: Diffing tests/stm/orig/stm-compiler-par/test8
cvs diff: Diffing tests/stm/orig/stm-compiler-par/test9
cvs diff: Diffing tests/stm/orig/stm-compiler-par-asm_fast
cvs diff: Diffing tests/stm/orig/stm-compiler-par-asm_fast/test1
cvs diff: Diffing tests/stm/orig/stm-compiler-par-asm_fast/test2
cvs diff: Diffing tests/stm/orig/stm-compiler-par-asm_fast/test3
cvs diff: Diffing tests/stm/orig/stm-compiler-par-asm_fast/test4
cvs diff: Diffing tests/stm/orig/stm-compiler-par-asm_fast/test5
cvs diff: Diffing tests/stm/orig/stm-compiler-par-asm_fast/test6
cvs diff: Diffing tests/stm/orig/stm-compiler-par-asm_fast/test7
cvs diff: Diffing tests/stm/orig/stm-compiler-par-asm_fast/test8
cvs diff: Diffing tests/stm/orig/stm-compiler-par-asm_fast/test9
cvs diff: Diffing tests/tabling
cvs diff: Diffing tests/term
cvs diff: Diffing tests/trailing
cvs diff: Diffing tests/valid
cvs diff: Diffing tests/warnings
cvs diff: Diffing tools
cvs diff: Diffing trace
cvs diff: Diffing util
cvs diff: Diffing vim
cvs diff: Diffing vim/after
cvs diff: Diffing vim/ftplugin
cvs diff: Diffing vim/syntax
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------
Previous message: [m-rev.] for post-commit review: optimizing goal features
Next message: [m-rev.] for review: duplicating fields from type defns to cons defns
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the reviews mailing list