[m-rev.] for review: fix bugs in parsing_utils.offset_to_line_number_and_position

Ralph Becket rafe at csse.unimelb.edu.au
Tue Aug 18 16:30:54 AEST 2009


Ian MacLarty, Tuesday, 18 August 2009:
> For review by Ralph.
> 
> Estimated hours taken: 4
> Branches: main
> 
> Fix bugs in parsing_utils when converting offsets to line numbers and
> positions.  One problem was that it was trying to index a zero length array
> when there was only one line in the source string.  Another bug was that it was
> using the wrong offset to compute the position.

Good catch!  That looks fine.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list