[m-rev.] for review: mmc --make --track-flags
Peter Wang
novalazy at gmail.com
Thu Apr 16 11:45:56 AEST 2009
2009/4/16 Julien Fischer <juliensf at csse.unimelb.edu.au>:
>>
>> +inconsequential_options(InconsequentialOptions) :-
>> + option_defaults_2(warning_option, WarningOptions),
>> + option_defaults_2(verbosity_option, VerbosityOptions),
>> + option_defaults_2(internal_use_option, InternalUseOptions),
>> + assoc_list.keys(WarningOptions, WarningKeys),
>> + assoc_list.keys(VerbosityOptions, VerbosityKeys),
>> + assoc_list.keys(InternalUseOptions, InternalUseKeys),
>> + Keys = WarningKeys ++ VerbosityKeys ++ InternalUseKeys,
>> + InconsequentialOptions = set.from_list(Keys).
>
> Is this predicate worth memoing?
It is a bit expensive, but usually the options from one module to the next
will be the same, then inconsequential_options won't be called very often.
Fixed the other things.
Peter
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to: mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions: mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------
More information about the reviews
mailing list