[m-rev.] for post-commit review: Coverage Profiling completed.

[Paul Bone]

On Fri, Sep 26, 2008 at 05:06:19PM +1000, Zoltan Somogyi wrote:
> 
> I did make two significant changes. First, I fixed a bug in the code that
> created the foreign_proc invocation of increment_coverage_pointer_counter:
> it used to set the instmap delta of the foreign_proc to say that it bound
> both its arguments, even though they are both input. Second, I added a
> new implementor-only option, --coverage-profiling-use-calls, that tells
> deep_profiling.m to generate a call to increment_coverage_pointer_counter
> instead of a foreign_proc. This should be useful if assertions are turned
> on.
>

Thanks Zoltan,

I'm not sure what the benefit of --coverage-profiling-use-calls is.
What assertions are you referring to that might prefer the increment
coverage point code to be called rather than inlined?  Are these the
runtime assertions within the instrumentation?

Thanks.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20080927/5b91219d/attachment.sig>