[m-rev.] For post-commit review: Changes to goal_path representation.

Paul Bone pbone at csse.unimelb.edu.au
Thu Sep 4 21:40:43 AEST 2008


On Thu, Sep 04, 2008 at 02:14:01PM +1000, Paul Bone wrote:
> On Mon, Sep 01, 2008 at 10:41:21PM +1000, Paul Bone wrote:
> > 
> > For review by anyone,
> > 
> > Please let me know if you think the names for the new goal_rep
> > predicates in program_representation.m are okay.
> > 
> > I've bootchecked in asm_fast.gc and asm_fast.gc.decldebug, and
> > asm_fast.gc.rbmm is running at the moment.
> > 
> > Estimated time taken: 3
> > Branches: main
> > 
> > Store goal paths as a reverse-sorted list rather than a cord.  This ensures
> > they are safe for use as keys in maps since their semantic and structual
> > representations are the same.  Goal paths are now an abstract type, make it
> > easy to change their representation in the future.
> > 
> > Modules in the program representation, and procedures in the module
> > representation are now stored in maps.
> > 
> 
> After some feedback from Zoltan I've updated the diff to use
> clearer function and procedure names for the goal path procedures.

This has now been commited for post-commit review.

Thanks.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20080904/b388c3e1/attachment.sig>


More information about the reviews mailing list