[m-rev.] for review: write out user sharing annotations to .opt files

Julien Fischer juliensf at csse.unimelb.edu.au
Mon Mar 3 20:06:23 AEDT 2008

On Mon, 3 Mar 2008, Peter Wang wrote:

> This would cause a mutual dependency between mercury_to_mercury.m and
> prog_data.m.  Maybe attributes_to_strings should be in
> mercury_to_mercury.m?

Based on a quick grep through the compiler directory, mercury_to_mercury
seems to be the only place that calls it anyway, so move it there.
(It should be renamed to something like
foreign_code_attributes_to_strings as there are few other declarations
that have attributes, e.g. pragma foreign_{decl, type, export_enum}, mutable.)

> Estimated hours taken: 2.5
> Branches: main
> Write out user-specified structure sharing annotations
> (no_sharing/unknown_sharing/sharing) on foreign_procs, e.g. when making `.opt'
> files.
> compiler/prog_data.m:
> 	Make `attributes_to_strings' take into account user sharing
> 	annotations.
> compiler/mercury_to_mercury.m:
> 	Conform to the change.
> tests/valid/Mercury.options:
> tests/valid/Mmakefile:
> tests/valid/intermod_user_sharing.m:
> tests/valid/intermod_user_sharing_2.m:
> 	Add a test case.

The diff is otherwise fine.

mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au

More information about the reviews mailing list