[m-rev.] for review: fix mantis bug #76

Julien Fischer juliensf at csse.unimelb.edu.au
Fri Aug 22 12:15:21 AEST 2008


On Tue, 19 Aug 2008, Peter Wang wrote:

> I'm not sure if this is correct in all the spots, but FWIW it bootchecks and
> passes the test suite.
>
> Branches: main
>
> Fix a compiler abort when writing out an intermodule optimisation file, the
> module for which has a typeclass instance of a typeclass that has a method with
> an existentially typed argument, but the predicate which implements
> the method is not itself existentially typed.  This is Mantis bug #76.
>
> compiler/prog_type.m:
> 	Make `arg_type_list_subsumes' possibly succeed if a callee may bind
> 	existential type variables in the caller, rather than failing.
>
> compiler/pred_table.m:
> 	Update `resolve_pred_overloading' and `find_matching_pred_id' to take
> 	extra arguments for `arg_type_list_subsumes'.
>
> 	Rename `get_pred_id' and `get_pred_id_and_proc_id' to be less
> 	ambiguous.
>
> compiler/intermod.m:
> compiler/modes.m:
> compiler/post_typecheck.m:
> compiler/purity.m:
> 	Conform to extra arguments and renamings.
>
> compiler/trans_opt.m:
> 	Delete an unused predicate.
>
> tests/valid/Mercury.options:
> tests/valid/Mmakefile:
> tests/valid/intermod_typeclass_exist.m:
> 	Add test case.

That looks okay.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list