[m-rev.] for review: emit error for non-visible types in instance decls

Julien Fischer juliensf at csse.unimelb.edu.au
Mon Oct 22 15:07:13 AEST 2007


On Fri, 19 Oct 2007, Julien Fischer wrote:

> Estimated hours taken: 2
> Branches: main
>
> Fix a bug where the compiler failed to emit an error if an exported instance
> declaration contained a type that was only visible in the implementation
> of the module.  (This is bug #11 in mantis.)
>
> compiler/check_typeclass.m:
> 	Check for the above situation and emit an error message.
>
> 	Unrelated change: fix the wording of another error message.
>
> 	Change some if-then-elses into switches.
>
> compiler/make_hlds_passes.m:
> 	Break an overlong line.
>
> tests/invalid/Mmakefile:
> tests/invalid/instance_no_type.{m,err_exp}:
> 	Test case for the new error message.

I am going to commit this. I will deal with any review comments
post-commit.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list