[m-rev.] For review: deconstruct non-canonical terms in pretty_printer.m

[Mark Brown]

On 11-Oct-2007, Ralph Becket <rafe at csse.unimelb.edu.au> wrote:
> Mark Brown, Thursday, 11 October 2007:
> > On 11-Oct-2007, Ralph Becket <rafe at csse.unimelb.edu.au> wrote:
> > > library/pretty_printer.m:
> > > 	Rename the format preds to write_doc.
> > > 
> > > 	Add an argument to the fully parameterised version of write_doc
> > > 	specifying whether non-canonical terms should be handled by
> > > 	just printing the type name and arity (`canonicalize') or by
> > > 	showing their structure (`include_details_cc').
> > > 
> > > 	Make the canonicalize version det and the include_details_cc version
> > > 	cc_multi and propagate the mode changes and extra argument
> > > 	through the code.
> > > 
> > > browser/browse.m:
> > > 	Call the new version of write_doc with include_details_cc in a
> > > 	promise_equivalent_solutions scope (this is sound because we're writing
> > > 	to stdout).
> > 
> > It would make sense to export write_doc_io from pretty_printer, to do
> > just this.
> > Aside from that and Julien's comment, this is fine to check in.
> 
> write_doc/[3,4] are exported.  Do you really want me to rename them?
> If I was going to rename anything, I'd change write_doc/9 to
> write_doc_to_stream/9.

Sure; I don't mind about the name.

Cheers,
Mark.

--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------