[m-rev.] for review: rbmm debugging/profiling grades

[Julien Fischer]

On Wed, 10 Oct 2007, Zoltan Somogyi wrote:

> Allow the specification of RBMM debugging and profiling via grades.
>
> runtime/mercury_grade.h:
> 	Add rbmmd and rbmmp as grade components denoting RBMM with debugging
> 	and profiling respectively, while rbmmdp is RBMM with both.
>
> compiler/options.m:
> 	Add --use-regions-debug and --use-regions-profiling as the Mercury
> 	compiler options specifying RBMM debugging and profiling.
>
> compiler/handle_options.m:
> 	Handle the new

Finish that sentence.

> compiler/compile_target_code.m:
> runtime/mercury_conf_param.h:
> scripts/canonical_grade.sh-subr:
> scripts/final_grade_options.sh-subr:
> scripts/init_grade_options.sh-subr:
> scripts/mgnuc.in:
> scripts/parse_grade_options.sh-subr:
> 	Handle the new grade components.
>
> configure.in:
> 	Add the new option --enable-rbmm-grades, for use by Quan and me
> 	for now, that causes the installation of all four RBMM grades.
> 	Once RBMM is ready for use by non-implementors, we can change this
> 	to install only the rbmm grade, and not the rbmmd/rbmmp/rbmmdp grades.
>
> cvs diff: Diffing .
> Index: configure.in
> ===================================================================
> RCS file: /home/mercury/mercury1/repository/mercury/configure.in,v
> retrieving revision 1.501
> diff -u -b -r1.501 configure.in
> --- configure.in	3 Oct 2007 12:11:53 -0000	1.501
> +++ configure.in	9 Oct 2007 16:19:11 -0000
> @@ -2918,6 +2918,11 @@
>                   [install a low level debugging version of the high level C grade]),
>    enable_hlc_ll_debug_grades="$enableval",enable_hlc_ll_debug_grades=no)
>
> +AC_ARG_ENABLE(rbmm-grades,
> +   AC_HELP_STRING([--enable-rbmm-grades],
> +                  [install experimental region-based memory management versions of the library]),
> +   enable_rbmm_grades="$enableval",enable_rbmm_grades=no)
> +
> # We don't enable the .NET grades by default because that may lead to
> # installation process breaking on Linux systems that have DotGNU or Mono
> # installed.
> @@ -2956,6 +2961,7 @@
> 	enable_dmm_grades=no
> 	enable_hlc_prof_grades=no
> 	enable_hlc_ll_debug_grades=no
> +	enable_rbmm_grades=no
> 	enable_par_grades=no
> 	enable_dotnet_grades=no
> 	enable_java_grade=no
> @@ -3131,6 +3137,12 @@
> 	LIBGRADES="$LIBGRADES hlc.gcd.ll_debug"
> fi
>
> +# Add rbmm grades
> +if test "$enable_rbmm_grades" = yes; then
> +	LIBGRADES="$LIBGRADES asm_fast.gc.rbmm \
> +		asm_fast.gc.rbmmd asm_fast.gc.rbmmp asm_fast.gc.rbmmdp"
> +fi

I suggest making that $BEST_LLDS_BASE_GRADE.gc.rbmmd etc, rather than
hardcoding the base grade as asm_fast.

The rest looks fine.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------