[m-rev.] for review: ssdb compiler scaffolding

[Peter Ross]

On 10/3/07, Zoltan Somogyi <zs at csse.unimelb.edu.au> wrote:
> On 03-Oct-2007, Peter Ross <pro at missioncriticalit.com> wrote:
> > ssdb/Mercury.options:
> > ssdb/Mmakefile:
> > ssdb/SSDB_FLAGS.in:
> >       Build system for ssdb directory.
>
> You will also need .mgnuc_opts and .mgnuc_copts files.
>
> You will also need to add to compiler/notes/overall_design.html.
>
Ok I will send that for review tomorrow.

> > Index: compiler/mercury_compile.m
> > ===================================================================
> > RCS file: /home/mercury1/repository/mercury/compiler/mercury_compile.m,v
> > retrieving revision 1.449
> > diff -u -r1.449 mercury_compile.m
> > --- compiler/mercury_compile.m        22 Aug 2007 07:14:34 -0000      1.449
> > +++ compiler/mercury_compile.m        3 Oct 2007 05:17:04 -0000
> > @@ -2563,6 +2563,9 @@
> >      maybe_termination2(Verbose, Stats, !HLDS, !IO),
> >      maybe_dump_hlds(!.HLDS, 121, "termination2", !DumpInfo, !IO),
> >
> > +    maybe_ssdb(Verbose, Stats, !HLDS, !IO),
> > +    maybe_dump_hlds(!.HLDS, 123, "ssdb", !DumpInfo, !IO),
> > +
>
> Why that stage?
>
Don't know, Peter Wang chose it, but it can easily be moved.

> > @@ -334,6 +340,7 @@
> >  mercury_profiling_builtin_module = unqualified("profiling_builtin").
> >  mercury_term_size_prof_builtin_module = unqualified("term_size_prof_builtin").
> >  mercury_par_builtin_module = unqualified("par_builtin").
> > +mercury_ssdb_builtin_module = unqualified("ssdb_builtin").
> >  mercury_std_lib_module_name(Name) = Name.
>
> I don't think this is right. The browser dir has a package name "mdb", I think
> the ssdb should too ("ssdb" and "mer_ssdb" are the obvious ones).
>
Ok will look into how to do that.

> > +handle_event(Event) :-
> > +    promise_impure (
> > +    trace [io(!IO)] (
> > +        io.write(Event, !IO),
> > +        io.nl(!IO)
> > +    )
> > +    ).
>
> Indentation.
>
The promise impure will be deleted soon, which is why I didn't change
the indentation.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------