[m-rev.] trivial diff: disable tests/valid/solver_type_mutable_bug
Julien Fischer
juliensf at csse.unimelb.edu.au
Fri Nov 23 14:47:11 AEDT 2007
Estimated hours: 0.1
Branches: main
Disable a test case that will no longer compile successfully due to
the change in r1.82 of compiler/inst_match.m. (The test checked that
mutable varsets were correct in the presence of automatic solver type
initialisation - there's not much point in fixing it will that is not
officially supported.)
tests/valid/Mmakefile:
Disable the solver_type_mutable_bug test.
tests/valid/solver_type_mutable_bug.m:
Add a comment to the head of this module explaining why we don't
run it.
Julien.
Index: Mmakefile
===================================================================
RCS file: /home/mercury/mercury1/repository/tests/valid/Mmakefile,v
retrieving revision 1.201
diff -u -r1.201 Mmakefile
--- Mmakefile 19 Nov 2007 06:36:30 -0000 1.201
+++ Mmakefile 23 Nov 2007 03:37:46 -0000
@@ -235,8 +235,7 @@
SOLVER_PROGS = \
solv \
- solver_type_bug_2 \
- solver_type_mutable_bug
+ solver_type_bug_2
DEEP_PROF_CAPABLE_PROGS = \
impure_detism
@@ -278,6 +277,13 @@
# XXX The following test is not valid under the current Mercury
# language rules:
# field_detism
+#
+# The following test case checked for a problem with the varsets attached
+# to mutables. It only ever worked in the presence of automatic solver
+# type initialisation, but due to subsequent changes in the mode analyser
+# it cannot currently be compiled.
+#
+# solver_type_mutable_bug
# The agc.* tests don't work in --high-level-code grades,
# except hl*.agc*, because they require grade-specific header
Index: solver_type_mutable_bug.m
===================================================================
RCS file: /home/mercury/mercury1/repository/tests/valid/solver_type_mutable_bug.m,v
retrieving revision 1.1
diff -u -r1.1 solver_type_mutable_bug.m
--- solver_type_mutable_bug.m 20 Mar 2006 22:24:30 -0000 1.1
+++ solver_type_mutable_bug.m 23 Nov 2007 03:42:59 -0000
@@ -1,3 +1,10 @@
+% Since rotd-2007-11-22 we have been unable to successfully compile this
+% test case due to the conjunction of (a) the removal of automatic solver
+% type initialisation and (b) the change to inst matching in r1.82 of
+% compiler/inst_match.m. Consequently, this test case is now disabled.
+% If some form of automatic solver type initialisation is added back to the
+% language in the future it should be re-enabled.
+%
% The following program, derived from msat.m by Ralph Becket, caused
% rotd-2006-03-19 to abort in deep profiling grades. The problem was that the
% varset attached to the mutable initialisation procedure was incorrect and
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to: mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions: mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------
More information about the reviews
mailing list