[m-rev.] for review: improve reporting of mode warnings

Ian MacLarty maclarty at csse.unimelb.edu.au
Mon May 28 11:09:47 AEST 2007


On Mon, May 28, 2007 at 02:41:58AM +0200, Peter Ross wrote:
> On Mon, May 28, 2007 at 08:42:17AM +1000, Ian MacLarty wrote:
> > For review by anyone.
> > 
> > Estimated hours taken: 5
> > Branches: main
> > 
> > Only report mode warnings if they occur in all modes.
> > simplify.m already had code to do this, so move this code to error_util.m and
> > reuse it in modes.m
> > 
> This sentence suggests that the mode warning code already existed in
> simplify, while it was only the code for checking for errors that occur
> in all modes that you copied out.
> 

Fixed and committed.

Thanks for the reviews.

Ian.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list