[m-rev.] for review: check instance declarations

[Simon Taylor]

On 21-May-2007, Peter Ross <pro at missioncriticalit.com> wrote:
> mercury/compiler/add_class.m:
>        Check that for all the "same" instance declarations
>        the instance constraints are exactly the same on each
>        declaration.

> Index: tests/invalid/incompatible_instance_constraints.err
> ===================================================================
> incompatible_instance_constraints.m:025: instance constraints incompatible
> incompatible_instance_constraints.m:014:   with instance constraints here.
> incompatible_instance_constraints.m:026: instance constraints incompatible
> incompatible_instance_constraints.m:017:   with instance constraints here.
> incompatible_instance_constraints.m:027: instance constraints incompatible
> incompatible_instance_constraints.m:018:   with instance constraints here.

The error message should start with a line describing the error site:
incompatible_instance_constraints.m:025: In instance declaration for class `tcl/1':

I'd also suggest using "instance constraints are incompatible with ...".

Other than that this change looks fine.

Simon.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------