[m-rev.] for review: fix missing foreign type errors

Julien Fischer juliensf at csse.unimelb.edu.au
Tue May 1 13:14:18 AEST 2007


On Tue, 1 May 2007, Simon Taylor wrote:

> Estimated hours taken: 3
> Branches: main
>
> Fix failure of tests/valid/foreign_type_spec.
>
> compiler/add_type.m:
> 	Fix a place where error codes were being `and'ed together
> 	rather than `or'ed, resulting in missing foreign type
> 	declarations not being reported and compiler aborts later.
>
> 	Remove code to only test GRADEFLAGS when generating code.
> 	GRADEFLAGS is passed for all compilation targets now.
>
> library/bitmap.m:
> 	Uncomment the IL definition of the bitmap type to allow
> 	this module to compile (but not work) in IL grades.
>
> tests/invalid/Mmakefile:
> tests/invalid/Mercury.options:
> tests/invalid/foreign_type_missing.{m,err_exp}:
> 	Test case for missing foreign type declarations for
> 	the current back-end.
>
> tests/valid/Mercury.options:
> 	Fix a typo which caused different parts of the foreign_type_spec
> 	test case to be compiled in different grades.

You should remove foreign_type_spec from 
tests/EXPECT_FAIL_TESTS.all_grades.

That looks fine otherwise.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list