[m-rev.] for review: allow comments and blank lines in mdb scripts

Ian MacLarty maclarty at csse.unimelb.edu.au
Fri Jun 15 17:36:11 AEST 2007


On Fri, Jun 15, 2007 at 05:18:02PM +1000, Julien Fischer wrote:
> 
>  On Fri, 15 Jun 2007, Ian MacLarty wrote:
> 
> > Ignore empty lines, or lines that start with `#', in sourced mdb scripts.
> > This is useful for formatting and documenting mdb scripts.
> >
> > Create a local copy of the mdbrc file so that we can test new mdb scripts
> > in the test suite.
> >
> > NEWS:
> > 	Mention the changes.
> >
> > configure.in:
> > 	Create a copy of mdbrc.in in the tests directory and create an mdbrc
> > 	from this file using different substitutions than those used for the
> > 	mdbrc that will be installed.  This is necessary so that we can use
> > 	the local mdbrc file when running the tests.  Previously if the mdbrc
> > 	file was changed (for example a new alias was added), then we had to
> > 	install it before testing.
> >
> > doc/user_guide.texi:
> > 	Document the new behaviour of the source command.
> >
> > scripts/mdb_grep:
> > scripts/mdb_open:
> > scripts/mdb_track:
> > 	Add comments to these mdb scripts.
> >
> > scripts/mdbrc.in:
> > 	Use a different substitution variable for the location of mdb_doc,
> > 	since for the test version of mdbrc mdb_doc will be in a different
> > 	location to the other scripts.
> >
> > tests/Mmake.common:
> > 	Get mdb to use the local mdbrc when invoked for the tests.
> >
> > 	Clean mdbrc and mdbrc.in.
> >
> > tests/debugger/Mercury.options:
> > tests/debugger/Mmakefile:
> > tests/debugger/scripts.exp:
> > tests/debugger/scripts.inp:
> > tests/debugger/scripts.m:
> > 	Add a test case for the three existing mdb scripts.
> >
> > trace/mercury_trace_readline.c:
> > trace/mercury_trace_readline.h:
> > 	Rename MR_trace_readline_expand_args to MR_trace_readline_from_script
> > 	and get it to ignore comment lines and blank lines.
> >
> > trace/mercury_trace_internal.c:
> > 	Adapt to changes in mercury_trace_readline.h.
> 
>  That looks fine.
> 

Actually I've just discovered that this screws up the formatting of the
mdb help, since whitespace is removed from the 'document' mdb commands.
I'll have a think about it and submit an interdiff.

Ian.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list