[m-rev.] for review: add --reset-kb option to mdb dd command

Julien Fischer juliensf at csse.unimelb.edu.au
Tue Jun 12 13:14:29 AEST 2007


On Mon, 11 Jun 2007, Peter Ross wrote:

> On 6/8/07, Julien Fischer <juliensf at csse.unimelb.edu.au> wrote:
>> 
>> On Fri, 8 Jun 2007, Peter Ross wrote:
>> 
>> > On 6/6/07, Ian MacLarty <maclarty at csse.unimelb.edu.au> wrote:
>> >> Index: browser/declarative_debugger.m
>> >> ===================================================================
>> >> RCS file:
>> >> /home/mercury1/repository/mercury/browser/declarative_debugger.m,v
>> >> retrieving revision 1.73
>> >> diff -u -r1.73 declarative_debugger.m
>> >> --- browser/declarative_debugger.m      1 Dec 2006 15:03:43 -0000
>> >> 1.73
>> >> +++ browser/declarative_debugger.m      5 Jun 2007 07:04:06 -0000
>> >> @@ -618,6 +618,19 @@
>> >>          SearchMode, Analyser0, Analyser),
>> >>      !:Diagnoser = !.Diagnoser ^ analyser_state := Analyser.
>> >>
>> >> +:- pred reset_knowledge_base(
>> >> +    diagnoser_state(trace_node_id)::in,
>> >> +    diagnoser_state(trace_node_id)::out) is det.
>> >> +
>> >> +:- pragma foreign_export("C",
>> >> +    mdb.declarative_debugger.reset_knowledge_base(in, out),
>> >> +    "MR_DD_decl_reset_knowledge_base").
>> >> +
>> >> +reset_knowledge_base(!Diagnoser) :-
>> >> +    Oracle0 = !.Diagnoser ^ oracle_state,
>> >> +    reset_oracle_knowledge_base(Oracle0, Oracle),
>> >> +    !Diagnoser ^ oracle_state := Oracle.
>> >> +
>> > Here you use the new !A ^ x := Y syntax, so you need to add a check to
>> > configure to check that we support this.
>> 
>> I've changed this part of Ian's to use the old syntax for now.
>> 
> There were other locations as well, so I've left my configure script 
> changes in.

Since the rotd wasn't building because of the slice directory for
quite a bit of last week, I think both they, and the your changes to
the configure script, should be removed for now.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list