[m-rev.] for review: add --reset-kb option to mdb dd command

[Ian MacLarty]

On Wed, Jun 06, 2007 at 04:07:26PM +1000, Julien Fischer wrote:
> 
>  On Wed, 6 Jun 2007, Ian MacLarty wrote:
> 
> > For review by anyone.
> >
> > Estimated hours taken: 1
> > Branches: main
> >
> > Add a --reset-kb option to the mdb `dd' command.  The new option resets the
> > declarative debugger's knowledge base of previous question answers.
> 
>  Since -R is also a synonym for this, I would prefer it if the long form
>  were `--reset-knowledge-base',  I find abbreviated forms like
>  `--reset-kb' difficult to remember.
> 

Okay.

>  (My initial thought on seeing this was: why do I want to reset the
>  keyboard?).
> 
> > NEWS:
> > 	Mention the new option.
> >
> > 	Move an item that was in the wrong place.
> >
> > browser/declarative_debugger.m:
> > browser/declarative_oracle.m:
> > 	Export a procedure to reset the oracle's knowledge base.
> >
> > doc/user_guide.texi:
> > 	Document the new option.
> >
> > tests/debugger/declarative/oracle_db.exp:
> > tests/debugger/declarative/oracle_db.inp:
> > 	Test the new option.
> >
> > trace/mercury_trace_cmd_dd.c:
> > trace/mercury_trace_declarative.c:
> > trace/mercury_trace_declarative.h:
> > 	Add the new option.
> >
> 
>  ...
> 
> > Index: doc/user_guide.texi
> > ===================================================================
> > RCS file: /home/mercury1/repository/mercury/doc/user_guide.texi,v
> > retrieving revision 1.522
> > diff -u -r1.522 user_guide.texi
> > --- doc/user_guide.texi	30 May 2007 05:15:06 -0000	1.522
> > +++ doc/user_guide.texi	5 Jun 2007 07:04:07 -0000
> > @@ -3977,7 +3977,7 @@
> > @ref{Declarative debugging} for details.
> > @sp 1
> > @table @code
> > - at item dd [-r] [-n at var{nodes}] [-s at var{search-mode}] [-p at var{passfile}] 
> > [-f at var{failfile}]
> > + at item dd [-r] [-R] [-n at var{nodes}] [-s at var{search-mode}] 
> > [-p at var{passfile}] [-f at var{failfile}]
> > @c @item dd [--assume-all-io-is-tabled] [-d at var{depth}] [-t]
> > @c       [--debug [filename]]
> > @c The --assume-all-io-is-tabled option is for developers only. Specifying 
> > it
> > @@ -4029,6 +4029,12 @@
> > The @samp{--search-mode} option may be used with the @samp{--resume} option
> > to change the search mode of a previously started declarative debugging
> > session.
> > + at sp 1
> > +Use the @samp{-R} or @samp{--reset-kb} option to reset the declarative
> > +debugger's knowledge base.
> > +The declarative debugger will then not use any previous answers you gave,
> > +and will reask previous questions if it needs to.
> 
>  reask? re-ask would be better.
> 
>  How about:
> 
>  	The declarative debugger will forget any previous answers that
>  	have been supplied.  It will ask previous questions again if
>  	it needs to.
> 

I used your suggestion.

>  Before committing please also check that the debugger tests are
>  up-to-date and working with both deep and shallow tracing enabled.
> 

Okay.

Ian.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------