[m-rev.] For review: Remove extraneous -- in ALL_MGNUCFLAGS

Julien Fischer juliensf at csse.unimelb.edu.au
Tue Jul 31 18:17:33 AEST 2007


On Mon, 30 Jul 2007, Eric Taucher wrote:

> Remove extraneous -- in ALL_MGNUCFLAGS
>
>
>
> scripts/Mmake.vars.in:
>
>            Clean up an extraneous -- when a previous option was removed.

What previous option are you referring to?


> Index: Mmake.vars.in
>
> ===================================================================
>
> RCS file: /home/mercury1/repository/mercury/scripts/Mmake.vars.in,v
>
> retrieving revision 1.107
>
> diff -u -r1.107 Mmake.vars.in
>
> --- Mmake.vars.in           14 Jul 2007 02:33:23 -0000         1.107
>
> +++ Mmake.vars.in        30 Jul 2007 12:44:38 -0000
>
> @@ -203,8 +203,7 @@
>
> FIX_PATH_FOR_CC      = @FIX_PATH_FOR_CC@
>
>
>
> MGNUC                       = mgnuc
>
> -ALL_MGNUCFLAGS     = $(MGNUCFLAGS) $(EXTRA_MGNUCFLAGS) $(TARGET_MGNUCFLAGS)
> \
>
> -                         -- $(ALL_CFLAGS)
>
> +ALL_MGNUCFLAGS    = $(MGNUCFLAGS) $(EXTRA_MGNUCFLAGS) $(TARGET_MGNUCFLAGS)
> $(ALL_CFLAGS)

That's not correct.  ALL_CFLAGS are flags that are intended to passed 
directly to the C compiler by the mgnuc script; they are not mgnuc flags.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list