[m-rev.] for review: fix libatomic (boehm_gc) configuration problem

Ben Schmidt b.schmidt at ugrad.unimelb.edu.au
Mon Jan 29 16:04:00 AEDT 2007


Committed, though with the original not the fixed log message. CVS died 
when I committed with the fixed message and I forgot to fix it when I 
tried the second time.

Ben.



Julien Fischer wrote:
> 
> On Mon, 29 Jan 2007, Ben Schmidt wrote:
> 
>> Is this a sensible fix to make?
> 
> Yes.
> 
>> Does it need to go on any special branch because boehm_gc is external 
>> (because of a vendor branch or something)?
> 
> No, just on the main branch.
> 
>> Estimated hours taken: 0
>> Branches: ???
>>
>> Tiny fix to libatomic configuration: put quotes around the CC definition
>> so that we have
>>     CC="gcc --grade=whatever ..."
>> not
>>     CC=gcc --grade=whatever ...
>> which, of course, fails with '--grade: command not found'.
>>
>> boehm_gc/libatomic_ops-1.2/configure.ac:
>>     Add quotes.
> 
>> boehm_gc/libatomic_ops-1.2/configure.ac:
>>     Hand-edited configure script incorporating the change.
> 
> s/configure.ac/configure there.
> 
>>     (Regenerating even using nominally the same versions of autoconf
>>     and automake generated a number of other differences.)
> 
> Boehm's use of autoconf is quite dodgy - it's not helped by the
> fact that the current version of the collector has two seperate
> configuration methods, the old one and the autoconf based one.
> 
> Julien.
> --------------------------------------------------------------------------
> mercury-reviews mailing list
> Post messages to:       mercury-reviews at csse.unimelb.edu.au
> Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
> Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
> --------------------------------------------------------------------------
> 
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list