[m-rev.] for review: fix libatomic (boehm_gc) configuration problem

Ben Schmidt b.schmidt at ugrad.unimelb.edu.au
Mon Jan 29 15:14:10 AEDT 2007


Is this a sensible fix to make? Does it need to go on any special branch 
because boehm_gc is external (because of a vendor branch or something)?

Ben.



Estimated hours taken: 0
Branches: ???

Tiny fix to libatomic configuration: put quotes around the CC definition
so that we have
	CC="gcc --grade=whatever ..."
not
	CC=gcc --grade=whatever ...
which, of course, fails with '--grade: command not found'.

boehm_gc/libatomic_ops-1.2/configure.ac:
	Add quotes.
boehm_gc/libatomic_ops-1.2/configure.ac:
	Hand-edited configure script incorporating the change.
	(Regenerating even using nominally the same versions of autoconf
	and automake generated a number of other differences.)




Index: configure
===================================================================
RCS file: 
/home/mercury/mercury1/repository/mercury/boehm_gc/libatomic_ops-1.2/configure,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 configure
--- configure	14 Aug 2006 03:14:42 -0000	1.1.1.1
+++ configure	25 Jan 2007 03:16:47 -0000
@@ -4723,7 +4723,7 @@

  AMDEP_TRUE="$AMDEP_TRUE" ac_aux_dir="$ac_aux_dir"
  PICFLAG=${PICFLAG}
-CC=${CC}
+CC="${CC}"
  DEFS=${DEFS}

  _ACEOF
Index: configure.ac
===================================================================
RCS file: 
/home/mercury/mercury1/repository/mercury/boehm_gc/libatomic_ops-1.2/configure.ac,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 configure.ac
--- configure.ac	14 Aug 2006 03:14:42 -0000	1.1.1.1
+++ configure.ac	25 Jan 2007 03:16:48 -0000
@@ -61,6 +61,6 @@

  AC_CONFIG_FILES([Makefile src/Makefile src/atomic_ops/Makefile 
src/atomic_ops/sysdeps/Makefile doc/Makefile tests/Makefile])
  AC_CONFIG_COMMANDS([default],[[]],[[PICFLAG=${PICFLAG}
-CC=${CC}
+CC="${CC}"
  DEFS=${DEFS}]])
  AC_OUTPUT
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list