[m-rev.] diff: fix `make install' for source distribution

[Julien Fischer]

On Wed, 10 Jan 2007, Ben Schmidt wrote:

>> Fix a bug that was causing `make install' to break when building
>> Mercury from the source distribution.
>
> I'd run across this problem, too, but hadn't looked into the cause.

The immediate cause was the change to allow sub-modules in the standard
library tickling an existing bug (which happened to be a workaround for
another bug ...)

>
>> @@ -5049,33 +5079,27 @@
> ...
>> +    % XXX The `<module>.all_int0s' variables is like `module.int0s' except
>
> s/module.int0s/<module>.int0s

Fixed.

>> +    % that it contains .int0 files for all modules, regardless of whether
>> +    % they should have been created or not.  It is used by the rule for
>> +    % `mmake realclean' to ensure that we clean up all the .int0 files,
>> +    % including the ones that were accidently created by the bug described
>> +    % above.
>
>> @@ -5688,7 +5712,7 @@
>>          "\t-echo $(", MakeVarName, ".optdates) | xargs rm -f\n",
>>          "\t-echo $(", MakeVarName, ".trans_opt_dates) | xargs rm -f\n",
>>          "\t-echo $(", MakeVarName, ".ints) | xargs rm -f\n",
>> -        "\t-echo $(", MakeVarName, ".int0s) | xargs rm -f\n",
>> +        "\t-echo $(", MakeVarName, ".all_int0s) | xargs rm -f\n",
>>          "\t-echo $(", MakeVarName, ".int3s) | xargs rm -f\n",
>>          "\t-echo $(", MakeVarName, ".opts) | xargs rm -f\n",
>>          "\t-echo $(", MakeVarName, ".trans_opts) | xargs rm -f\n",
>
> It may be worth documenting near here that the use of all_int0s is a 
> workaround; just a short comment referring to the earlier comment.

Done.

> Otherwise, looks good.

Thanks for that.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------