[m-rev.] for review: implicit option for target x86-64

[Julien Fischer]

On Tue, 9 Jan 2007, Fransiska Nathania HANDOKO wrote:

>
> Estimated hours taken: 1

Since the release branch is (in principle) still active at the moment
you should also mention which branch this change applies to.

> This change adds few lines of codes to handle options when compiling
> to x86_64 assembler.

That says _what_ is changing; equally important is _why_ it changing.
I suggest:

 	When compiling to x86_64 assembler do not enable
 	--use-local-vars since this optimization only makes sense
 	if the target language is C.

> compiler/handle_options.m:
> 	Add codes to set an implicit option when compiling to x86_64
> 	assembler. The option is 'use_local_vars'. The default for
> 	this is 'no'.

Or more simply:

 	`--target x86_64' implies `--no-use-local-vars'.

The change itself is fine.  You can commit that after you have
modified the log message.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------