[m-rev.] for review: fix taking label addresses in standard library

Peter Wang wangp at students.csse.unimelb.edu.au
Tue Feb 6 21:50:28 AEDT 2007


On 2007-02-06, Julien Fischer <juliensf at csse.unimelb.edu.au> wrote:
> On Tue, 6 Feb 2007, Peter Wang wrote:
> 
> >Branches: main
> >library/thread.m:
> >library/thread.semaphore.m:
> >	Don't take the addresses of labels in spawn/3, semaphore.signal/3 and
> >	semaphore.wait/3 as that is a gcc extension.  This also fixes a crash
> >	in spawn/3 on x86 when the Mercury standard library is dynamically
> >	linked.
> >
> >library/par_builtin.m:
> >	Rename symbols for module initialisation to be more similar to other
> >	modules.
> 
> I spoke too soon - there is a problem with this diff.
> 
> Note that the #ifndef protecting this piece of code, specifically
> #ifndef MR_HIGHLEVEL_CODE, doesn't match that below for the entry
> and definition of mercury__thread__semaphore__nop (which require
> MR_THREAD_SAFE to be defined).

Fixed.  Sorry about that.

Peter

--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list