[m-rev.] diff: string splitting routines to string.m

[Julien Fischer]

On Fri, 2 Feb 2007, Ralph Becket wrote:

>> Index: library/string.m
>> ===================================================================
>> RCS file: /home/mercury/mercury1/repository/mercury/library/string.m,v
>> retrieving revision 1.254
>> diff -u -r1.254 string.m
>> --- library/string.m	18 Jan 2007 07:33:03 -0000	1.254
>> +++ library/string.m	1 Feb 2007 07:32:18 -0000
>> @@ -367,6 +367,11 @@
>>      %
>>  :- func string.chomp(string) = string.
>>
>> +    % string.chomp(Tail, String):
>> +    % `String' minus `Tail' if `String' ends with `Tail', `String'
>> otherwise
>> +    %
>> +:- func string.chomp(string, string) = string.
>> +
>
> We already have the pred string.remove_suffix.  I would rather you added
> a function version of string.remove_suffix (`chomp' isn't a good name,
> even if it's used in millions of Perl scripts).

We also already have string.chomp/1, so at the least I would prefer 
something with a distinct name.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------