[m-rev.] for post-commit review: rbmm.point_to_graph.m cleanup

Quan Phan quan.phan at cs.kuleuven.be
Mon Dec 31 11:41:31 AEDT 2007


Hi,

On Sun, Dec 30, 2007 at 03:19:36PM +1100, Zoltan Somogyi wrote:
> For post-commit review by Quan.
> 
> Zoltan.
> 
> compiler/rbmm.points_to_graph.m:
> 	Clean up a few things. Give some fields names and use those names
> 	in getters and setters, give some other fields better names, keep
> 	the rpt_graph type private to the module, use a counter for allocating
> 	numbers.
> 
> compiler/rbmm.points_to_analysis.m:
> compiler/rbmm.live_region_analysis.m:
> 	Conform to the above change.
> 
...
> +rptg_set_node_supply(NS, !G) :-
> +    !:G = !.G ^ rptg_node_supply := NS.
Updating a field of state variables now can be written shorter:
!X ^ field = value. I will make this a bit later.

The rest looks fine to me. Thanks for doing this improvement.

Regards,
Quan.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list