[m-rev.] for review: fix problem with parallel mmc --make and --rebuild

[Julien Fischer]

On Mon, 27 Aug 2007, Peter Wang wrote:

> Index: ./compiler/make.util.m
> ===================================================================
> RCS file: /home/mercury/mercury1/repository/mercury/compiler/make.util.m,v
> retrieving revision 1.49
> diff -u -r1.49 make.util.m
> --- ./compiler/make.util.m	17 Aug 2007 02:04:13 -0000	1.49
> +++ ./compiler/make.util.m	27 Aug 2007 03:37:16 -0000
> @@ -64,8 +64,9 @@
>     % concurrently, in any order, and multiple times.
>     %
> :- pred foldl2_maybe_stop_at_error_maybe_parallel(bool::in,
> -    foldl2_pred_with_status(T, Info, io)::in(foldl2_pred_with_status),
> -    list(T)::in, bool::out, Info::in, Info::out, io::di, io::uo) is det.
> +    foldl2_pred_with_status(T, make_info, io)::in(foldl2_pred_with_status),
> +    list(T)::in, bool::out, make_info::in, make_info::out, io::di, io::uo)
> +    is det.
>
> %-----------------------------------------------------------------------------%
>
> @@ -305,9 +306,11 @@
> :- import_module transform_hlds.
> :- import_module transform_hlds.mmc_analysis.
>
> +:- import_module bool.
> :- import_module char.
> :- import_module dir.
> :- import_module exception.
> +:- import_module getopt_io.
> :- import_module set.
> :- import_module thread.
> :- import_module thread.channel.
> @@ -420,8 +423,12 @@
>     % Second pass (sequential).
>     (
>         Success0 = yes,
> +        % Disable the `--rebuild' option during the sequential pass.

I suggest mentioning why they need to be disabled here.

The rest of the change look okay.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------