[m-rev.] for review: rbmm info in goal_infos

Quan Phan Quan.Phan at cs.kuleuven.be
Sat Aug 4 23:02:27 AEST 2007


Hi,

> For review (of the changes to hlds_goal.m) by Quan. The other changes
> are trivial.

Do the comments below make sense? I would like to keep them (or some modified 
one) there. There are several invariants:
- A region may be in only one of the first three sets.
- If a region is in the firsrt set, it will not be in any other set.
- A region in the second or third sets may also be in the fourth or fifth sets.

The rest looks fine for me.

Regards,
Quan

PS: I had sent this email twice but did not receive it from this mailing list 
myseft. So sorry if you receive multiple versions and for the delay.
  
 Index: compiler/hlds_goal.m
 ===================================================================
 RCS file: /home/mercury/mercury1/repository/mercury/compiler/hlds_goal.m,v
 retrieving revision 1.179
 diff -u -b -r1.179 hlds_goal.m
 --- compiler/hlds_goal.m	2 Aug 2007 01:24:00 -0000	1.179
 +++ compiler/hlds_goal.m	2 Aug 2007 03:21:49 -0000
 @@ -832,18 +832,139 @@
  
 +
 +:- type rbmm_goal_info
 +    --->    rbmm_goal_info(
                  % Regions that will be created inside the goal.
 +                created_regions         :: set(prog_var),

                  % Regions that exist before the goal and will be removed
                  % inside it.
 +                removed_regions         :: set(prog_var),

                  % Regions that exist before the goal and will not be
                  % removed inside it.
 +                carried_regions         :: set(prog_var),
 +
                  % Regions that exist before the goal and may be allocated
                  % into inside it.
 +                allocated_into_regions  :: set(prog_var),

                  % Regions that exist before the goal and may be read from
                  % inside it.
 +                used_regions            :: set(prog_var)
 +            ).
 +

--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list