[m-rev.] for review: make mmc --make not symlink target file unnecessarily

[Peter Wang]

On 2007-04-11, Ian MacLarty <maclarty at csse.unimelb.edu.au> wrote:
> > Index: compiler/compile_target_code.m
> > ===================================================================
> > RCS file: /home/mercury/mercury1/repository/mercury/compiler/compile_target_code.m,v
> > retrieving revision 1.105
> > diff -u -r1.105 compile_target_code.m
> > --- compiler/compile_target_code.m	2 Mar 2007 02:56:37 -0000	1.105
> > +++ compiler/compile_target_code.m	11 Apr 2007 02:54:22 -0000
> > @@ -104,13 +104,16 @@
> >  :- pred link(io.output_stream::in, linked_target_type::in, module_name::in,
> >      list(string)::in, bool::out, io::di, io::uo) is det.
> >  
> > -    % post_link_make_symlink_or_copy(TargetType, MainModuleName, Succeeded)
> > +    % post_link_make_symlink_or_copy(TargetType, MainModuleName, Succeeded,
> > +    %   DidSomething)
> >      %
> >      % If `--use-grade-subdirs' is enabled, link or copy the executable or
> > -    % library into the user's directory after having successfully built it.
> > +    % library into the user's directory after having successfully built it,
> > +    % if the target does not exist or is not up-to-date.
> >      %
> 
> Perhaps describe the DidSomething argument in the comments, or alternatively
> change its name to MadeSymLinkOrCopy.

I did that latter. Thanks.

Peter
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------