[m-rev.] diff: workaround deep profiler bug

Julien Fischer juliensf at csse.unimelb.edu.au
Fri Apr 6 16:08:30 AEST 2007


On Fri, 6 Apr 2007, Mark Brown wrote:

> On 06-Apr-2007, Ian MacLarty <maclarty at csse.unimelb.edu.au> wrote:
>> On Thu, Apr 05, 2007 at 12:45:37PM +1000, Julien Fischer wrote:
>>> Estimated hours taken: 5 recently, lots more in the past.
>>> Branches: main
>>>
>>> Workaround the problem that has been causing the deep profiler to seg fault.
>>>
>> ...
>>> Index: tests/general/Mercury.options
>>> ===================================================================
>>> RCS file: /home/mercury/mercury1/repository/tests/general/Mercury.options,v
>>> retrieving revision 1.2
>>> diff -u -r1.2 Mercury.options
>>> --- tests/general/Mercury.options	26 Jul 2004 00:35:48 -0000	1.2
>>> +++ tests/general/Mercury.options	5 Apr 2007 02:39:27 -0000
>>> @@ -20,3 +20,13 @@
>>>  # tracking it down.
>>>  MLFLAGS-string_test = --no-strip
>>>
>>> +# If the compiler is build in a .profdeep grade then attempting to compile
>>> +# these tests with `--warn-known-bad-format-call' will abort since the
>>> +# code that implements that check catches an exception.  The deep profiler
>>> +# cannot currently handle code that catches exceptions.
>>> +# Also, it's not worth doing the check for these test cases anyway since
>>> +# the entire point of them is to check that string.format is aborts when
>>> +# passed an invalid format string.
>>
>> You have a small typo here.
>
> I see two errors.

Fixed.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list