[m-rev.] for review: programatically turn profiling on and off

Zoltan Somogyi zs at csse.unimelb.edu.au
Tue Sep 26 09:59:46 AEST 2006


On 25-Sep-2006, Peter Ross <pro at missioncriticalit.com> wrote:
> Provided no-one sees problems with this change.  The next plan is
> to add a library module which allows one to turn profiling on and
> off as impure predicates.

That looks fine, with two exceptions. You use ints to store booleans;
you should use MR_bool instead. Second, it looks like you mixed indentation
via spaces into source files indented by tabs. I don't care which one we
use, but we should be consistent.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list