[m-rev.] trivial diff: avoid a warning in samples/rot13

Ralph Becket rafe at csse.unimelb.edu.au
Mon Sep 11 13:22:45 AEST 2006


Zoltan Somogyi, Monday, 11 September 2006:
> I'd say it should stay turned on. The original writer of the code may know
> what he/she meant, but later readers cannot assume this (unless the writer
> puts in a comment to that effect, but then renaming would accomplish that
> objective even more clearly).

Lambdas are almost always small; I have no problem recognizing
shadowing.

On the other hand, renaming often makes code less readable (e.g., what
is a good renaming for the IO state in a lambda?)

--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list