[m-rev.] for review: support call sequence numbers in the deep profiler

[Julien Fischer]

On Wed, 11 Oct 2006, Zoltan Somogyi wrote:

> deep_profiler/measurements.m:
> 	Standardize on one spelling of call sequence numbers (callseqs).
>
> 	Add some utility predicates for use in dump.m.
>
> 	Fix a bug in the calculation of the number of calls: redos enter
> 	procedure invocations, not leave them.
>
> deep_profiler/profile.m:
> 	Fix a bug: the num_callseqs field was in the wrong place.
>
> deep_profiler/html_format.m:
> 	When generating a line of the clique description, include call sequence
> 	number information if requested.
>
> 	Do likewise when generating other HTML fragments that have to match
> 	the contents of those lines (e.g. the table headers).
>
> 	Generate the links that allow the users to sort rows by call
> 	sequence numbers.
>
> 	Generate the links that allow the users to toggle the switches
> 	controlling the display of call sequence number information.
>
> 	Do not show the toggles relevant to the display of times if times are
> 	not being displayed.
>
> deep_profiler/interface.m:
> 	Extend the preferences to allow requests for call sequence number
> 	information.
>
> 	Include the display of call sequence numbers in the default set of
> 	preferences. However, include the display of time information in the
> 	default only of the profiling run lasted long enough for this
> 	information to have some hope of being useful.
>
> 	Rename some function symbols to avoid ambiguities.
>
> deep_profiler/query.m:
> 	Extend the menu to include links for the most expensive
> 	cliques/procedures as measured by call sequence numbers.
>
> 	Include the links for the most expensive cliques/procedures as
> 	measured by clock ticks in the menu only if the profiling run
> 	lasted long enough for this to be useful.
>
> 	Print out the total number of call sequence numbers with the other
> 	statistics.
>
> 	Use call sequence numbers instead of time to decide where the "action"
> 	begins, since this works even for short profiling runs.
>
> deep_profiler/top_procs.m:
> 	Provide the capability of sorting on call sequence numbers.
>
> deep_profiler/dump.m:
> 	Provide the capability to dump out several more fields of the top level
> 	structure (profile.deep), including the cliques, the reverse links and
> 	the propagated measurement information.
>
> deep_profiler/startup.m:
> 	Dump out the cliques, the reverse links and the propagated measurement
> 	information when computed.
>
> deep_profiler/mdprof_cgi.m:
> 	Add an option for setting the hostname in the generated links to
> 	"localhost". This is useful on laptops temporarily disconnected
> 	from the Domain Name System (e.g. my laptop).
>
> 	Set this option automatically if the name of the file in the initial
> 	query has a ".localhost" suffix added to it.
>
> 	Add some tracing hooks.
>
> deep_profiler/mdprof_test.m:
> 	Add an option to specify what info to dump during startup.
>
> deep_profiler/mdprof_dump.m:
> 	Switch to using the compiler's method of specifying what to dump,
> 	since this is more maintainable.
>
> deep_profiler/exclude.m:
> 	Rename some function symbols to avoid ambiguities.
>
> deep_profiler/timeout.m:
> 	Add conditionally compiled code to help debug lock management.
>
> deep_profiler/callgraph.m:
> deep_profiler/canonical.m:
> deep_profiler/cliques.m:
> deep_profiler/conf.m:
> deep_profiler/read_profile.m:
> 	Minor cleanups.

That looks fine - you should also update the NEWS file to mention that
the deep profiler now supports profiling using calling sequence numbers.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------