[m-rev.] for review: smaller stacks for parallel conjuncts

[Peter Wang]

On 2006-10-02, Peter Wang <wangp at students.csse.unimelb.edu.au> wrote:
> On 2006-10-02, Julien Fischer <juliensf at csse.unimelb.edu.au> wrote:
> > >
> > >@sp 1
> > >+ at item --small-detstack-size @var{size}
> > >+ at findex --small-detstack-size (runtime option)
> > >+Sets the size of the det stack used for executing parallel conjunctions
> > >+to @var{size} kilobytes.
> > >+The regular det stack size should be equal or greater to avoid surprises.
> > 
> > The initialisation code in the runtime should check that this is the case 
> > and
> > abort (with a suitable error message) if not.  The documention here should 
> > say
> > that is the case rather than some vague mention of surprises.  (Similarly 
> > for
> > the nondet stack etc.)
> 
> Will do.

Committed this.


Estimated hours taken: 0.1
Branches: main

tests/hard_coded/Mmakefile:
tests/hard_coded/runtime_opt.exp:
tests/hard_coded/runtime_opt.inp:
	Update this test case.  It would report an error message when the
	chosen --detstack-size was less than the default --small-detstack-size.


Index: tests/hard_coded/Mmakefile
===================================================================
RCS file: /home/mercury1/repository/tests/hard_coded/Mmakefile,v
retrieving revision 1.296
diff -u -r1.296 Mmakefile
--- tests/hard_coded/Mmakefile	16 Sep 2006 10:46:40 -0000	1.296
+++ tests/hard_coded/Mmakefile	4 Oct 2006 23:50:15 -0000
@@ -630,7 +630,7 @@
 # is created by concatenating all of the outputs from each run.
 runtime_opt.out: runtime_opt runtime_opt.inp
 	( \
-		for option in `cat runtime_opt.inp`; do \
+		cat runtime_opt.inp | while read option; do \
 			echo "Option \`$$option':"; \
 			MERCURY_OPTIONS="$$option" ./runtime_opt 2>&1 || true; \
 			echo ""; \
Index: tests/hard_coded/runtime_opt.exp
===================================================================
RCS file: /home/mercury1/repository/tests/hard_coded/runtime_opt.exp,v
retrieving revision 1.1
diff -u -r1.1 runtime_opt.exp
--- tests/hard_coded/runtime_opt.exp	28 Aug 2006 10:13:23 -0000	1.1
+++ tests/hard_coded/runtime_opt.exp	4 Oct 2006 23:51:27 -0000
@@ -1,10 +1,10 @@
-Option `--nondetstack-size-kwords=256':
+Option `--nondetstack-size-kwords=256 --small-nondetstack-size-kwords=256':
 Hello world (with non-standard options).
 
-Option `--nondet-stack-size-kwords=256':
+Option `--nondet-stack-size-kwords=256 --small-nondet-stack-size-kwords=256':
 Hello world (with non-standard options).
 
-Option `--detstack-size=128':
+Option `--detstack-size=128 --small-detstack-size=128':
 Hello world (with non-standard options).
 
 Option `--this-is-not-a-real-option':
Index: tests/hard_coded/runtime_opt.inp
===================================================================
RCS file: /home/mercury1/repository/tests/hard_coded/runtime_opt.inp,v
retrieving revision 1.1
diff -u -r1.1 runtime_opt.inp
--- tests/hard_coded/runtime_opt.inp	28 Aug 2006 10:13:23 -0000	1.1
+++ tests/hard_coded/runtime_opt.inp	4 Oct 2006 23:48:34 -0000
@@ -1,4 +1,4 @@
---nondetstack-size-kwords=256
---nondet-stack-size-kwords=256
---detstack-size=128
+--nondetstack-size-kwords=256 --small-nondetstack-size-kwords=256
+--nondet-stack-size-kwords=256 --small-nondet-stack-size-kwords=256
+--detstack-size=128 --small-detstack-size=128
 --this-is-not-a-real-option
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------