[m-rev.] for review: [CTGC] indirect reuse analysis.

Julien Fischer juliensf at cs.mu.OZ.AU
Mon May 29 22:56:55 AEST 2006


On Mon, 29 May 2006, Nancy wrote:

> >> Index: compiler/structure_reuse.direct.detect_garbage.m
> >> ===================================================================
> >> RCS file: /home/mercury1/repository/mercury/compiler/structure_reuse.direct.detect_garbage.m,v
> >> retrieving revision 1.1
> >> diff -u -d -r1.1 structure_reuse.direct.detect_garbage.m
> >> --- compiler/structure_reuse.direct.detect_garbage.m	10 May 2006 10:56:56 -0000	1.1
> >> +++ compiler/structure_reuse.direct.detect_garbage.m	18 May 2006 12:01:12 -0000
> >> @@ -90,6 +90,7 @@
> >>                  func(C) = G :- (G = C ^ case_goal), Cases), !SharingAs,
> >>              !DeadCellTable)
> >>      ;
> >> +        % XXX
> >
> > Why has that XXX comment been added there?
>
> I'm planning to explicitly recheck all the handling of the negations...
> As I need to recheck that with the theory.
> I've specified the reason for the XXX now.
>

That's fine - I just wasn't sure what XXX by itself meant.

...

> I'll commit this part...

Go ahead.  Out of curiosity how much stuff is left to be merged in from
the reuse branch.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list