[m-rev.] for post-commit review: optimize compilation of trail ops

[Julien Fischer]

On Fri, 31 Mar 2006, Zoltan Somogyi wrote:

> compiler/code_gen.m:
> 	Don't test whether we are emitting trail operations when generating
> 	*every* goal; test it only when generating goals that may want to
> 	emit trailing operations. Make the test itself more efficient
> 	by doing option lookups and boolean operations on option values
> 	once per procedure rather than once per affected goal.
>
> compiler/code_info.m:
> 	Extend the code_info structure to provide storage space for the
> 	result of this per-procedure computation.
>
> compiler/code_util.m:
> 	Delete a function whose functionality is now in code_info.m.
>
> compiler/goal_form.m:
> 	Turn the predicates that test whether a goal can modify the trail
> 	into functions, since that is how they were being used. Make them
> 	take only the goal_info as the argument, since the goal expression
> 	isn't needed, and creating the expression/goal_info pair would be
> 	an unnecessary cost on the code generator.
>
> compiler/add_trail_ops.m:
> compiler/disj_gen.m:
> 	Conform to the change in goal_form.m.
>
> compiler/mercury_compile.m:
> 	Fix formatting.
>
> compiler/assertion.m:
> 	Address some old review comments: fix some bad predicate names,
> 	and put some predicate's arguments into a more conventional order.
>
> 	Remove some redundant and slightly inconsistent documentation.
>
> compiler/accumulator.m:
> compiler/typecheck.m:
> 	Conform to the change in assertion.m.

That look okay.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------