[m-rev.] for review: delete RTTI predicates from std_util

Julien Fischer juliensf at cs.mu.OZ.AU
Wed Mar 22 13:54:30 AEDT 2006


On Wed, 22 Mar 2006, Zoltan Somogyi wrote:

> Remove from std_util.m the predicates that merely call predicates in
> the type_desc, construct and deconstruct modules, to reduce clutter
> in std_util.m.
>
> library/std_util.m:
> 	Remove those predicates from std_util.m.
>
> library/deconstruct.m:
> 	Add a type we need that was previously defined in std_util.m.
>
> library/construct.m:
> 	Delete some module qualifications that have now become unnecessary,
>
> browser/browse.m:
> browser/browser_info.m:
> browser/declarative_tree.m:
> browser/dl.m:
> browser/help.m:
> browser/sized_pretty.m:
> browser/term_rep.m:
> compiler/bytecode_gen.m:
> compiler/llds_out.m:
> compiler/mlds_to_il.m:
> compiler/mlds_to_managed.m:
> library/assoc_list.m:
> library/hash_table.m:
> library/io.m:
> library/pprint.m:
> library/private_builtin.m:
> library/prolog.m:
> library/require.m:
> library/rtti_implementation.m:
> library/store.m:
> library/term.m:
> library/term_to_xml.m:
> library/version_hash_table.m:
> mdbcomp/program_representation.m:
> 	Import type_desc.m, construct.m and/or deconstruct.m to provide
> 	definitions of functions or predicates that up till now were in
> 	std_util.m. Modify the calls if the called function or predicate
> 	had a slightly different interface in std_util.m.
>
> 	Also, convert term_to_xml.m to four-space indentation, and delete
> 	unnecessary module qualifications in term.m.
>
> tests/debugger/polymorphic_output.{m,inp,exp,exp2}:
> tests/hard_coded/copy_pred_2.m:
> tests/hard_coded/deconstruct_arg.exp:
> tests/hard_coded/deconstruct_arg.exp2:
> tests/hard_coded/deconstruct_arg.m:
> tests/hard_coded/elim_special_pred.m:
> tests/hard_coded/existential_bound_tvar.m:
> tests/hard_coded/expand.m:
> tests/hard_coded/foreign_type2.m:
> tests/hard_coded/higher_order_type_manip.m:
> tests/hard_coded/nullary_ho_func.m:
> tests/hard_coded/tuple_test.m:
> tests/hard_coded/type_ctor_desc.m:
> tests/hard_coded/type_qual.m:
> tests/hard_coded/write_xml.m:
> tests/hard_coded/sub-modules/class.m:
> tests/hard_coded/sub-modules/nested.m:
> tests/hard_coded/sub-modules/nested2.m:
> tests/hard_coded/sub-modules/nested3.m:
> tests/hard_coded/sub-modules/parent.m:
> tests/hard_coded/sub-modules/parent2.child.m:
> tests/hard_coded/typeclasses/existential_rtti.m:
> tests/recompilation/type_qual_re.m.1:
> cvs update: Updating tests/submodules
> cvs update: Updating tests/tabling
> cvs update: Updating tests/term
> cvs update: Updating tests/tools
> cvs update: Updating tests/trailing
> cvs update: Updating tests/typeclasses
> cvs update: Updating tests/valid
> tests/valid/agc_unbound_typevars.m:
> tests/valid/agc_unbound_typevars2.m:
> tests/valid/agc_unused_in.m:
> 	Replace references to the deleted predicates in std_util with
> 	references to the equivalent predicates in type_desc, construct
> 	and/or deconstruct. In test cases that already tested both the
> 	functionality in std_util and in the other modules, simply delete
> 	the part exercising std_util.
>

That looks fine.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list