[m-rev.] for review: fix asm_fast.par.gc

[Julien Fischer]

On Tue, 7 Mar 2006, Peter Wang wrote:

> Estimated hours taken: 8
> Branches: main
>
> Fix a few problems in the low-level parallel grade.
>
> compiler/par_conj_gen.m:
> runtime/mercury_context.h:
> 	Fix some off-by-one bugs introduced when `MR_sp' was changed to mean
> 	the last used word on the det stack, rather than the first free word.
>
> 	Update references to renamed fields in the MR_Context structure.
>
> 	Change some `assert' calls to `MR_assert'.
>
> Index: compiler/par_conj_gen.m
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/compiler/par_conj_gen.m,v
> retrieving revision 1.21
> diff -u -r1.21 par_conj_gen.m
> --- compiler/par_conj_gen.m	17 Nov 2005 15:57:26 -0000	1.21
> +++ compiler/par_conj_gen.m	6 Mar 2006 12:06:49 -0000
> @@ -264,7 +264,7 @@
>  copy_outputs(CI, [Var | Vars], SpSlot, Code) :-
>      code_info__get_variable_slot(CI, Var, SrcSlot),
>      ( SrcSlot = stackvar(SlotNum) ->
> -        NegSlotNum = (- SlotNum),
> +        NegSlotNum = (1 - SlotNum),
>          DestSlot = field(yes(0), lval(SpSlot), const(int_const(NegSlotNum)))

It's probably worth adding a comment about that there.  Otherwise that's
fine.  Does this change fix any of the problems with the lowlevel .par
grades?

Julien.

--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------