[m-rev.] for review: fix failure of debugger/declarative/sort.m

[Ian MacLarty]

On Thu, Jun 08, 2006 at 03:02:44PM +1000, Julien Fischer wrote:
> 
> For review by Ian or Zoltan.
> 
> Estimated hours taken: 3
> Branches: main, release
> 
> Fix the failure of debugger/declarative/sort.m.  The problem was that the
> depth command in the declarative debugger did not affect the depth to which
> I/O actions were printed.  This was because printing I/O actions uses the
> `print all' configuration parameters and the `depth' command in the
> declarative debugger only affects the `print' configuration parameters.  The
> solution is to add four new formatting commands to the declarative debugger
> (really just variants of the existing commands.)  These are `depth io', `size
> io', `lines io' and `width io'.  These function identically to the `depth',
> `size', `lines' and `width' commands except that they affect the `print all'
> configuration parameters, rather the ones for `print'.
> 
> browser/declarative_user.m:
> 	Add the four new commands described above.
> 
> doc/user_guide.texi:
> 	Document the new commands.
> 
> browser/declarative_debugger.m:
> 	Fix some formatting.
> 
> tests/debugger/declarative/sort.inp:
> tests/debugger/declarative/sort.exp:
> 	Use the new commands set the depth to which I/O actions are printed in
> 	the declarative debugger to an appropriate level for this test - it
> 	needs to be deep enough to print out the strings returned by
> 	read_line_as_string_2.
> 
> tests/debugger/declarative/dd_params.exp:
> tests/debugger/declarative/dd_params.inp:
> 	Extend this test to cover the new commands.
> 

...

> Index: doc/user_guide.texi
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/doc/user_guide.texi,v
> retrieving revision 1.479
> diff -u -r1.479 user_guide.texi
> --- doc/user_guide.texi	7 Jun 2006 06:14:04 -0000	1.479
> +++ doc/user_guide.texi	8 Jun 2006 04:05:11 -0000
> @@ -4323,16 +4323,29 @@
>  @item depth @var{num}
>  Set the maximum depth to which terms are printed to @var{num}.
>  @sp 1
> + at item depth io @var{num}
> +Set the maximum depth to which I/O actions are printed to @var{num}.
> + at sp 1
>  @item size @var{num}
>  Set the maximum number of function symbols
>  to be printed in terms to @var{num}.
>  @sp 1
> + at item size io @var{num}
> +Set the maximum number of function symbols
> +to be printed in I/O actions to @var{num}.
> + at sp 1
>  @item width @var{num}
>  Set the number of columns in which terms are to be printed to @var{num}.
>  @sp 1
> + at item width io @var{num}
> +Set the number of columns in which I/O actions are to be printed to @var{num}.
> + at sp 1
>  @item lines @var{num}
>  Set the maximum number of lines in terms to be printed to @var{num}.
>  @sp 1
> + at item lines io @var{num}
> +Set the maximum number of lines in I/O actions to be printed to @var{num}.
> + at sp 1

You should probably mention that these commands also update the
print-all format parameters in mdb.

Otherwise that looks fine.

Ian.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------