[m-rev.] for review: disallow d.u. dummy types with user-defind uc

Julien Fischer juliensf at cs.mu.OZ.AU
Tue Jun 6 18:20:04 AEST 2006


On Tue, 6 Jun 2006, Ian MacLarty wrote:

> On Wed, May 31, 2006 at 03:51:48PM +1000, Julien Fischer wrote:
> >
> > For review by anyone.
> >
> > This was discussed on mercury-developers the other day.  The consensus
> > there was that this was the preferable solution.
> >
> > Estimated hours taken: 4
> > Branches: main, release
> >
> > Do not allow discriminated unions with a single zero-arity constructor to have
> > user-defined equality or comparison.  Defining such types causes an assertion
> > failure in the compiler because the types are considered to be dummy types and
> > the runtime currently doesn't support (and probably won't ever) d.u. dummy
> > types with user-defined equality or comparison.
> >
> > Fix another bug that where the compiler was not printing out the recompile
> > with `-E' prompt at the appropriate time.
>
> Delete "that".  I also suggest putting quotes around "recompile with `-E'".
>

Done.

I've subsequently discovered that this change affects most of the expected
outputs in tests/invalid because the `recompile with -E' prompt was not
being printed out when it should have been.

> Otherwise that looks fine.

Thanks for that; I'll commit this after I've fixed the expected outputs
in tests/invalid.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list